-
-
Notifications
You must be signed in to change notification settings - Fork 516
Improved devcontainer setup with e2e test mini infra #2672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 97.39% 97.41% +0.01%
==========================================
Files 135 135
Lines 5229 5229
==========================================
+ Hits 5093 5094 +1
+ Misses 136 135 -1
🚀 New features to boost your workflow:
|
9c29d73
to
1830579
Compare
76a9bbf
to
e4724c2
Compare
I tried running it on mac and linux both, neither works. We need to make this work without vscode since I do not use it. On linux, the error is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some questions and it does not work for me, will wait for fixes/instructions and continue then
@sl0thentr0py please try again:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, shipit
This reworks our devcontainer setup so that it uses pre-built base images grabbed from ghcr.io and enables running e2e tests easily both on CI and locally.
There's a top level setup now in the root dir under
spec
where we can write high-level cross-gem e2e tests.This is a solid foundation for building even more conveniences around development/debugging/testing in the future 🙂
To run e2e tests locally you can simply do:
#skip-changelog