chore(ci): Fixes iOS binary size diff failure #5144
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c59bb69.
This reverts commit 54af75e.
Co-authored-by: LucasZF <[email protected]>
This reverts commit 8f067d0.
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9bd7d3 | 403.74 ms | 385.54 ms | -18.20 ms |
| f139dae | 415.36 ms | 400.73 ms | -14.63 ms |
| 6c67a16 | 442.07 ms | 454.91 ms | 12.84 ms |
| ba483fc | 407.51 ms | 398.52 ms | -8.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9bd7d3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| f139dae | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 6c67a16 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ba483fc | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae+dirty | 383.66 ms | 389.28 ms | 5.62 ms |
| f9bd7d3+dirty | 403.83 ms | 442.76 ms | 38.92 ms |
| ba483fc+dirty | 432.91 ms | 454.14 ms | 21.23 ms |
| 6c67a16+dirty | 408.86 ms | 440.96 ms | 32.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| f9bd7d3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| ba483fc+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 6c67a16+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
Previous results on branch: antonis/increase-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 375.33 ms | 431.26 ms | 55.93 ms |
| 268fd4c+dirty | 366.98 ms | 408.04 ms | 41.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 268fd4c+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae+dirty | 1213.82 ms | 1215.87 ms | 2.05 ms |
| ba483fc+dirty | 1203.07 ms | 1213.62 ms | 10.55 ms |
| 6c67a16+dirty | 1220.52 ms | 1223.47 ms | 2.95 ms |
| f9bd7d3+dirty | 1224.46 ms | 1237.04 ms | 12.58 ms |
| 8b9ad38+dirty | 1218.50 ms | 1213.23 ms | -5.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| ba483fc+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 6c67a16+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| f9bd7d3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 8b9ad38+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
Previous results on branch: antonis/increase-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 1230.43 ms | 1223.81 ms | -6.62 ms |
| 268fd4c+dirty | 1211.45 ms | 1210.80 ms | -0.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 268fd4c+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c67a16+dirty | 1218.27 ms | 1224.22 ms | 5.96 ms |
| f9bd7d3+dirty | 1207.15 ms | 1216.72 ms | 9.57 ms |
| ba483fc+dirty | 1211.24 ms | 1220.49 ms | 9.24 ms |
| f139dae+dirty | 1220.86 ms | 1233.21 ms | 12.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c67a16+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| f9bd7d3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba483fc+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| f139dae+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
Previous results on branch: antonis/increase-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 1229.94 ms | 1230.94 ms | 1.00 ms |
| 268fd4c+dirty | 1227.55 ms | 1220.45 ms | -7.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2f84e2+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 268fd4c+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
…_flags # Conflicts: # CHANGELOG.md # packages/core/RNSentry.podspec
This was referenced Sep 5, 2025
Base automatically changed from
antonis/remove_cocoa_flags
to
deps/scripts/update-cocoa.sh
September 5, 2025 09:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on: #5038
📜 Description
I've noticed that metrics ios check has started to fail consistently (though marginally) due to small changes in the size of the app (example job run) after the Cocoa bump to 8.55.0
Notes:
💡 Motivation and Context
Ci failure
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog