Skip to content

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Jul 31, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5144

📜 Description

Rollback Cocoa 8.53.2 workaround

💡 Motivation and Context

Fixes #4991

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.60 ms 415.57 ms 6.97 ms
Size 17.75 MiB 19.68 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64cd15c 439.02 ms 427.63 ms -11.39 ms
ba75c7c 367.72 ms 369.16 ms 1.44 ms
5526494 440.84 ms 448.36 ms 7.52 ms
534ba8c 484.00 ms 499.93 ms 15.93 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
98f632c 424.25 ms 435.48 ms 11.23 ms
a0b15d6 423.06 ms 437.77 ms 14.71 ms
46bd012 387.09 ms 404.47 ms 17.38 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms

App size

Revision Plain With Sentry Diff
64cd15c 17.75 MiB 20.15 MiB 2.41 MiB
ba75c7c 17.75 MiB 20.15 MiB 2.41 MiB
5526494 17.75 MiB 19.68 MiB 1.93 MiB
534ba8c 17.75 MiB 20.15 MiB 2.41 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
98f632c 17.75 MiB 20.15 MiB 2.41 MiB
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: antonis/revert_breadcrumb_data_workaround

Startup times

Revision Plain With Sentry Diff
27b24bb 438.30 ms 453.15 ms 14.85 ms

App size

Revision Plain With Sentry Diff
27b24bb 17.75 MiB 19.68 MiB 1.94 MiB

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 415.82 ms 454.04 ms 38.22 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

@antonis antonis marked this pull request as ready for review August 14, 2025 12:44
Copy link
Contributor

github-actions bot commented Aug 14, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.73 ms 1233.74 ms -5.99 ms
Size 3.19 MiB 4.48 MiB 1.29 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
c4e097a+dirty 1231.35 ms 1246.91 ms 15.56 ms
46bd012+dirty 1231.78 ms 1212.30 ms -19.47 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
eb07ba3+dirty 1214.49 ms 1221.59 ms 7.10 ms
3e0a5f9+dirty 1233.65 ms 1239.10 ms 5.45 ms
20d5eaa+dirty 1224.67 ms 1223.16 ms -1.51 ms
5526494+dirty 1217.06 ms 1222.26 ms 5.20 ms
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms
46da307+dirty 1213.45 ms 1207.96 ms -5.49 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
c4e097a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
46bd012+dirty 3.19 MiB 4.38 MiB 1.19 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
eb07ba3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
3e0a5f9+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20d5eaa+dirty 3.19 MiB 4.38 MiB 1.19 MiB
5526494+dirty 3.19 MiB 4.44 MiB 1.25 MiB
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB
46da307+dirty 3.19 MiB 4.44 MiB 1.25 MiB

Previous results on branch: antonis/revert_breadcrumb_data_workaround

Startup times

Revision Plain With Sentry Diff
27b24bb+dirty 1215.26 ms 1212.70 ms -2.56 ms

App size

Revision Plain With Sentry Diff
27b24bb+dirty 3.19 MiB 4.48 MiB 1.29 MiB

@antonis antonis marked this pull request as draft August 14, 2025 12:57
@antonis antonis force-pushed the antonis/revert_breadcrumb_data_workaround branch from 3a77e1e to 75c10ee Compare September 5, 2025 08:15
@antonis antonis changed the base branch from antonis/remove_cocoa_flags to antonis/increase-ios-binary-size September 5, 2025 08:16
@antonis antonis marked this pull request as ready for review September 5, 2025 08:18
Copy link
Contributor

github-actions bot commented Sep 5, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.16 ms 1229.54 ms 6.38 ms
Size 2.63 MiB 3.91 MiB 1.28 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
c4e097a+dirty 1229.09 ms 1242.61 ms 13.53 ms
46bd012+dirty 1220.49 ms 1226.89 ms 6.40 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
eb07ba3+dirty 1222.46 ms 1220.37 ms -2.08 ms
3e0a5f9+dirty 1226.94 ms 1230.02 ms 3.08 ms
20d5eaa+dirty 1231.12 ms 1226.00 ms -5.12 ms
5526494+dirty 1224.73 ms 1229.08 ms 4.36 ms
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms
46da307+dirty 1217.08 ms 1224.16 ms 7.08 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
c4e097a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
46bd012+dirty 2.63 MiB 3.81 MiB 1.18 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
eb07ba3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
3e0a5f9+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20d5eaa+dirty 2.63 MiB 3.81 MiB 1.18 MiB
5526494+dirty 2.63 MiB 3.87 MiB 1.24 MiB
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB
46da307+dirty 2.63 MiB 3.87 MiB 1.24 MiB

Previous results on branch: antonis/revert_breadcrumb_data_workaround

Startup times

Revision Plain With Sentry Diff
27b24bb+dirty 1222.54 ms 1216.45 ms -6.09 ms

App size

Revision Plain With Sentry Diff
27b24bb+dirty 2.63 MiB 3.91 MiB 1.28 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from antonis/increase-ios-binary-size to deps/scripts/update-cocoa.sh September 5, 2025 09:44
Base automatically changed from deps/scripts/update-cocoa.sh to main September 5, 2025 09:48
@antonis antonis enabled auto-merge (squash) September 5, 2025 09:48
@antonis antonis disabled auto-merge September 5, 2025 09:49
@antonis antonis enabled auto-merge (squash) September 5, 2025 09:49
@antonis antonis merged commit 1853710 into main Sep 5, 2025
64 of 65 checks passed
@antonis antonis deleted the antonis/revert_breadcrumb_data_workaround branch September 5, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollback Cocoa 8.53.2 workaround
3 participants