-
Notifications
You must be signed in to change notification settings - Fork 536
chore: Make start_span
fail if unsupported args are provided
#4201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
33d6f1b
chore: Remove start_span(sampled=X)
sentrivana 2a853a4
let it fail loudly rather than silently
sentrivana bad71c7
Deprecate more stuff
sentrivana fb74530
.
sentrivana af6cc5b
Merge branch 'potel-base' into ivana/potel/remove-custom-sampled
sentrivana ec1dd3a
bring back description
sentrivana a4cf07e
desc
sentrivana 4163da0
.
sentrivana fe1e82e
.
sentrivana 7277307
...
sentrivana 6753840
readd desc to spankwargs
sentrivana bb46a2a
Merge branch 'potel-base' into ivana/potel/remove-custom-sampled
sentrivana 07c12d5
Revert "chore: Remove start_span(sampled=X)"
sentrivana 8b8ef5e
oversight
sentrivana bc3f4e7
Merge branch 'potel-base' into ivana/potel/remove-custom-sampled
sentrivana 8aabeb7
.
sentrivana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't make sense to propagate the
sampled
flag to the children as it's only taken into account for root spans in the sampler (by design)