chore: Make start_span fail if unsupported args are provided
#4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4201 +/- ##
==============================================
+ Coverage 83.58% 83.61% +0.03%
==============================================
Files 144 144
Lines 14661 14663 +2
Branches 2323 2324 +1
==============================================
+ Hits 12254 12261 +7
+ Misses 1688 1685 -3
+ Partials 719 717 -2
|
sentrivana
changed the title
Span interface
szokeasaurusrex
approved these changes
Apr 8, 2025
|
Reverted the |
sentrivana
added a commit
that referenced
this pull request
Apr 9, 2025
Preparing to remove this in #4201
sentrivana
changed the title
Span interfacestart_span fail if unsupported args are provided
sentrivana
commented
Apr 9, 2025
| @@ -543,7 +540,7 @@ def timestamp(self): | |||
|
|
|||
| def start_child(self, **kwargs): | |||
| # type: (**Any) -> Span | |||
| return Span(sampled=self.sampled, parent_span=self, **kwargs) | |||
| return Span(parent_span=self, **kwargs) | |||
There was a problem hiding this comment.
Doesn't make sense to propagate the sampled flag to the children as it's only taken into account for root spans in the sampler (by design)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
Spanconstructor actually fail if it gets unsupported arguments, as opposed to silently ignoring them, so that folks get notified early.Deprecating some of these in #4244
Closes #4200