Skip to content

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 4, 2025

Remove most of the binary images for the test resources for the NSException tests, because they aren't required for the tests.

Follow up on #6653.

#skip-changelog

Closes #6659

Remove most of binary images for the tests resources for the NSException
tests, because they aren't required for the tests.
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.148%. Comparing base (a4e1541) to head (65bf417).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6658       +/-   ##
=============================================
+ Coverage   84.960%   85.148%   +0.187%     
=============================================
  Files          452       452               
  Lines        27668     27668               
  Branches     12115     12119        +4     
=============================================
+ Hits         23507     23559       +52     
+ Misses        4113      4062       -51     
+ Partials        48        47        -1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e1541...65bf417. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-7,291 lines of code 😄 I like it, LGTM when CI is green

@philipphofmann philipphofmann merged commit 6528493 into main Nov 4, 2025
138 of 140 checks passed
@philipphofmann philipphofmann deleted the test/remove-binary-images branch November 4, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Subset of binary images for NSExceptionTests

3 participants