test(session-replay): Add masking tests for special views #6571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
Member
Author
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
graphite-app
bot
changed the base branch from
philprime/fix-masking_split_4
to
graphite-base/6571
Merge activity
|
philprime
added a commit
that referenced
this pull request
Nov 5, 2025
philprime
added a commit
that referenced
this pull request
Nov 6, 2025
…in (#6678) * fix(session-replay): Update rendering method for fast view rendering (#6360) * fix(session-replay): Extend masking and focus masking on sensitive information (#6292) * test(session-replay): Add masking tests for common cases (#6567) * test(session-replay): Add masking tests for React Native views (#6568) * fix(session-replay): Fix conversion of frame rate to time interval (#6623) * test(session-replay): Add masking tests for edge cases (#6569) * test(session-replay): Add masking tests for UIKit views (#6570) * test(session-replay): Add masking tests for special views (#6571) * fix(session-replay): Include layer background color when checking if a view is opaque (#6629) * chore(tests): Remove snapshot testing to reduce repository size (#6631) * chore: Remove unwanted CHANGELOG entries from cherry-pick - Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes * docs: Move changelog changes from v8.57.1 to unreleased * test: Resolve wrong assertions involed due to merge-conflict * chore: Update sdk_api_V9.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #6292 for stacked merging