Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 28, 2025

Derived from #6292 for stacked merging

#skip-changelog

cursor[bot]

This comment was marked as outdated.

Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests

Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
@philprime philprime self-assigned this Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3938 1 3937 55
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.80 ms 1261.57 ms 30.77 ms
Size 23.75 KiB 1.01 MiB 1016.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7bb24a2 1229.16 ms 1256.66 ms 27.50 ms
1f48bb7 1223.83 ms 1241.85 ms 18.02 ms
1b008ee 1209.57 ms 1258.67 ms 49.10 ms
c2982e7 1223.92 ms 1242.86 ms 18.94 ms
a6f5396 1211.81 ms 1245.63 ms 33.82 ms
94a6b1a 1213.39 ms 1231.55 ms 18.17 ms
736bcfb 1229.86 ms 1249.59 ms 19.73 ms
8d944ac 1236.92 ms 1254.91 ms 18.00 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms

App size

Revision Plain With Sentry Diff
7bb24a2 23.75 KiB 973.68 KiB 949.93 KiB
1f48bb7 23.75 KiB 971.98 KiB 948.24 KiB
1b008ee 23.75 KiB 929.71 KiB 905.96 KiB
c2982e7 23.75 KiB 911.62 KiB 887.87 KiB
a6f5396 23.75 KiB 989.12 KiB 965.38 KiB
94a6b1a 23.75 KiB 902.48 KiB 878.74 KiB
736bcfb 23.74 KiB 891.02 KiB 867.28 KiB
8d944ac 23.75 KiB 919.69 KiB 895.94 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB

Previous results on branch: philprime/fix-masking_split_4

Startup times

Revision Plain With Sentry Diff
1340945 1216.00 ms 1246.08 ms 30.08 ms

App size

Revision Plain With Sentry Diff
1340945 23.75 KiB 1.01 MiB 1016.12 KiB

@philprime philprime changed the base branch from graphite-base/6570 to philprime/fix-masking_split_3 October 29, 2025 14:17
@philprime
Copy link
Member Author

After feedback from @noahsmartin I need to remove unnecessary snapshots before merging

@philprime philprime marked this pull request as draft October 29, 2025 14:57
@philprime philprime marked this pull request as ready for review November 3, 2025 12:09
Base automatically changed from philprime/fix-masking_split_3 to main November 3, 2025 12:27
@graphite-app
Copy link

graphite-app bot commented Nov 3, 2025

Merge activity

  • Nov 3, 12:27 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 3, 12:27 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@philprime philprime enabled auto-merge (squash) November 3, 2025 12:36
cursor[bot]

This comment was marked as outdated.

@philprime philprime merged commit dced702 into main Nov 3, 2025
178 of 180 checks passed
@philprime philprime deleted the philprime/fix-masking_split_4 branch November 3, 2025 13:29
philprime added a commit that referenced this pull request Nov 6, 2025
…in (#6678)

* fix(session-replay): Update rendering method for fast view rendering (#6360)
* fix(session-replay): Extend masking and focus masking on sensitive information (#6292)
* test(session-replay): Add masking tests for common cases (#6567)
* test(session-replay): Add masking tests for React Native views (#6568)
* fix(session-replay): Fix conversion of frame rate to time interval (#6623)
* test(session-replay): Add masking tests for edge cases (#6569)
* test(session-replay): Add masking tests for UIKit views (#6570)
* test(session-replay): Add masking tests for special views (#6571)
* fix(session-replay): Include layer background color when checking if a view is opaque (#6629)
* chore(tests): Remove snapshot testing to reduce repository size (#6631)
* chore: Remove unwanted CHANGELOG entries from cherry-pick
- Remove #5591 (minimum OS version warnings) - not related to session replay
- Remove #6019 (SCNetworkReachability) - not related to session replay
- Remove #6377 (thread event issue) - not related to session replay
- Remove #6381 (frame delay) - duplicate/not related to session replay
- Keep only session replay masking related changes
* docs: Move changelog changes from v8.57.1 to unreleased
* test: Resolve wrong assertions involed due to merge-conflict
* chore: Update sdk_api_V9.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants