chore: implement Display for error types by Micah-Shallom · Pull Request #879 · getfloresta/Floresta

Micah-Shallom · 2026-03-10T09:26:46Z

Description

Closes #667.

Implements Display for all error types that were missing it, allowing them to be integrated into custom error types using thiserror and #[error(transparent)].

Error Types Updated

MemoryDatabaseError — floresta-watch-only
HeaderExtError — floresta-chain
FlatChainstoreError — floresta-chain
BlockchainBuilderError — floresta-chain
LeafErrorKind — floresta-chain
slip132::Error — floresta-node

AI was used to help identify error types missing Display implementations across the codebase

moisesPompilio

The commit is missing a description; it only has the title

moisesPompilio · 2026-03-10T14:07:39Z

crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs

 use crate::ChainStore;
 use crate::DatabaseError;
 use crate::DiskBlockHeader;
+use core::fmt;


I think the position of this import is not here; did you get to run the format or lint on the code?

My bad.. I have amended this..Thanks

jaoleal

Heres some superficial review. Still need to check if the imports are correct

jaoleal · 2026-03-10T14:48:32Z

crates/floresta-chain/src/pruned_utreexo/flat_chain_store.rs

+            FlatChainstoreError::Io(e) => write!(f, "I/O error: {}", e),
+            FlatChainstoreError::BlockNotFound => write!(f, "Block not found"),
+            FlatChainstoreError::IndexIsFull => write!(f, "Index is full"),
+            FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {}", v),


Suggested change

FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {}", v),

FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {v}"),

jaoleal · 2026-03-10T14:48:44Z

crates/floresta-chain/src/pruned_utreexo/flat_chain_store.rs

+impl fmt::Display for FlatChainstoreError {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {
+            FlatChainstoreError::Io(e) => write!(f, "I/O error: {}", e),


Suggested change

FlatChainstoreError::Io(e) => write!(f, "I/O error: {}", e),

FlatChainstoreError::Io(e) => write!(f, "I/O error: {e}"),

jaoleal · 2026-03-10T14:48:58Z

crates/floresta-chain/src/pruned_utreexo/flat_chain_store.rs

+            FlatChainstoreError::IndexIsFull => write!(f, "Index is full"),
+            FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {}", v),
+            FlatChainstoreError::Poisoned => write!(f, "Poisoned"),
+            FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {}", m),


Suggested change

FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {}", m),

FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {m}"),

jaoleal · 2026-03-10T14:49:13Z

crates/floresta-chain/src/pruned_utreexo/udata.rs

+        fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+            match self {
+                LeafErrorKind::EmptyStack => write!(f, "Empty stack"),
+                LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {}", e),


Suggested change

LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {}", e),

LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {e}"),

jaoleal · 2026-03-10T14:49:27Z

crates/floresta-chain/src/extensions.rs

+impl fmt::Display for HeaderExtError {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {
+            HeaderExtError::Chain(e) => write!(f, "Chain error: {}", e),


Suggested change

HeaderExtError::Chain(e) => write!(f, "Chain error: {}", e),

HeaderExtError::Chain(e) => write!(f, "Chain error: {e}"),

jaoleal · 2026-03-10T14:50:38Z

crates/floresta-node/src/slip132.rs

+            Error::InvalidChildNumberFormat => write!(f, "Invalid child number format"),
+            Error::InvalidDerivationPathFormat => write!(f, "Invalid derivation path format"),
+            Error::UnknownVersion(v) => write!(f, "Unknown version: {:?}", v),
+            Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {}", l),


Suggested change

Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {}", l),

Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {I}"),

jaoleal · 2026-03-10T17:02:08Z

crates/floresta-watch-only/src/memory_database.rs

 type Result<T> = floresta_common::prelude::Result<T, MemoryDatabaseError>;

+impl Display for MemoryDatabaseError {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {


Suggested change

fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {

fn fmt(&self, f: &mut Formatter<'_>) -> Result {

jaoleal · 2026-03-10T17:04:15Z

crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs

+impl fmt::Display for BlockchainBuilderError {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {


Not sure if those could be called withtout fmt::. If theres any conflict you can leave as it is, besides that, prefer importing

importing would work for Display and FOrmatter but wouldnt for Result due to shadowing of Rusts's default Result with the one we define.....so i just decided to use fmt:: for all of them for uniformity instead of mixing prefixed and unprefixed imports

Import like this:

use core::fmt; use core::fmt::Display; use core::fmt::Formatter

Hi @luisschwab ..this has been done...thanks

jaoleal · 2026-03-10T17:04:27Z

crates/floresta-chain/src/pruned_utreexo/flat_chain_store.rs

+impl fmt::Display for FlatChainstoreError {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {


https://github.com/getfloresta/Floresta/pull/879/changes#r2913194467

the fix has been implemented @jaoleal

jaoleal · 2026-03-10T17:04:35Z

crates/floresta-chain/src/pruned_utreexo/udata.rs

+    impl fmt::Display for LeafErrorKind {
+        fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {


https://github.com/getfloresta/Floresta/pull/879/changes#r2913194467

jaoleal · 2026-03-10T20:12:43Z

See: #876

Micah-Shallom · 2026-03-11T02:43:02Z

@jaoleal thanks for you reviews.. i looked at #876 you pointed me to... noticed @luisschwab also raised the same issue where there would be a conflict with the non-fmt Result preluded automatically by rust

I'll make Display and Formatter unprefixed and keep Result as fmt::Result to avoid the conflict. Let me know if you'd prefer I keep fmt:: on all three for uniformity instead.

Micah-Shallom · 2026-03-22T20:33:44Z

hi @moisesPompilio , all review feedback has been addressed on this PR.....would appreciate a re-review..thank you.

moisesPompilio · 2026-03-23T22:49:48Z

crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs

+            BlockchainBuilderError::MissingChainstore => write!(f, "Missing chainstore"),
+            BlockchainBuilderError::MissingChainParams => write!(f, "Missing chain parameters"),
+            BlockchainBuilderError::IncompleteTip => write!(f, "Incomplete tip"),
+            BlockchainBuilderError::Database(e) => write!(f, "Database error: {:?}", e),


Suggested change

BlockchainBuilderError::Database(e) => write!(f, "Database error: {:?}", e),

BlockchainBuilderError::Database(e) => write!(f, "Database error: {e:?}"),

moisesPompilio · 2026-03-23T22:52:05Z

crates/floresta-node/src/slip132.rs

+            Error::InvalidChildNumber(n) => write!(f, "Invalid child number: {}", n),
+            Error::InvalidChildNumberFormat => write!(f, "Invalid child number format"),
+            Error::InvalidDerivationPathFormat => write!(f, "Invalid derivation path format"),
+            Error::UnknownVersion(v) => write!(f, "Unknown version: {:?}", v),


This still needs to be applied.

Implement Display trait for error types that were missing it, enabling integration with thiserror and #[error(transparent)]. Error types updated: MemoryDatabaseError, HeaderExtError, FlatChainstoreError, BlockchainBuilderError, LeafErrorKind, slip132::Error.

luisschwab · 2026-03-26T15:56:54Z

@Micah-Shallom please don't request reviews like this. I removed it for a reason.

Micah-Shallom · 2026-03-26T15:57:22Z

apologies @luisschwab ....i didnt know you removed it and thought my network was bad and so i kept punching the request review button...

moisesPompilio assigned Micah-Shallom Mar 10, 2026

moisesPompilio added enhancement New feature or request code quality Generally improves code readability and maintainability labels Mar 10, 2026

moisesPompilio suggested changes Mar 10, 2026

View reviewed changes

moisesPompilio added the BDK Floresta Issues related to the integration of Floresta in BDK label Mar 10, 2026

Micah-Shallom force-pushed the chore/implement-display-for-error-types branch 2 times, most recently from f336be8 to 06ba469 Compare March 10, 2026 14:24

moisesPompilio self-requested a review March 10, 2026 15:03

jaoleal reviewed Mar 10, 2026

View reviewed changes

Micah-Shallom force-pushed the chore/implement-display-for-error-types branch from 06ba469 to 993dfd5 Compare March 11, 2026 02:45

csgui added reliability Related to runtime reliability, stability and production readiness and removed enhancement New feature or request code quality Generally improves code readability and maintainability labels Mar 11, 2026

csgui added this to the Q2/2026 milestone Mar 11, 2026

csgui removed the BDK Floresta Issues related to the integration of Floresta in BDK label Mar 12, 2026

Micah-Shallom force-pushed the chore/implement-display-for-error-types branch from 993dfd5 to a4c83a6 Compare March 12, 2026 22:31

Micah-Shallom force-pushed the chore/implement-display-for-error-types branch from a4c83a6 to dcab56a Compare March 22, 2026 20:30

moisesPompilio suggested changes Mar 23, 2026

View reviewed changes

moisesPompilio requested a review from jaoleal March 23, 2026 22:52

Micah-Shallom force-pushed the chore/implement-display-for-error-types branch from dcab56a to 1c97642 Compare March 24, 2026 02:44

Micah-Shallom requested review from luisschwab and moisesPompilio March 24, 2026 02:49

luisschwab removed their request for review March 26, 2026 15:50

Micah-Shallom requested a review from luisschwab March 26, 2026 15:55

luisschwab removed their request for review March 26, 2026 15:57

none34829 mentioned this pull request Apr 4, 2026

fix(chain,compact-filters): replace Debug delegation in Display impls with per-variant messages #937

Open

	FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {}", v),
	FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {v}"),

	FlatChainstoreError::Io(e) => write!(f, "I/O error: {}", e),
	FlatChainstoreError::Io(e) => write!(f, "I/O error: {e}"),

	FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {}", m),
	FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {m}"),

	LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {}", e),
	LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {e}"),

	HeaderExtError::Chain(e) => write!(f, "Chain error: {}", e),
	HeaderExtError::Chain(e) => write!(f, "Chain error: {e}"),

	Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {}", l),
	Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {I}"),

	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
	fn fmt(&self, f: &mut Formatter<'_>) -> Result {

		impl fmt::Display for BlockchainBuilderError {
		fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {

		impl fmt::Display for LeafErrorKind {
		fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {

	BlockchainBuilderError::Database(e) => write!(f, "Database error: {:?}", e),
	BlockchainBuilderError::Database(e) => write!(f, "Database error: {e:?}"),

Conversation

Micah-Shallom commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Error Types Updated

Uh oh!

moisesPompilio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaoleal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaoleal commented Mar 10, 2026

Uh oh!

Micah-Shallom commented Mar 11, 2026

Uh oh!

Micah-Shallom commented Mar 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luisschwab commented Mar 26, 2026

Uh oh!

Micah-Shallom commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Micah-Shallom commented Mar 10, 2026 •

edited

Loading

Micah-Shallom commented Mar 26, 2026 •

edited

Loading