chore: implement Display for error types

Implement Display trait for error types that were missing it, enabling integration with thiserror and #[error(transparent)].

Error types updated: MemoryDatabaseError, HeaderExtError, FlatChainstoreError, BlockchainBuilderError, LeafErrorKind, slip132::Error.

Author: Micah-Shallom

crates/floresta-chain/src/extensions.rs

@@ -1,4 +1,7 @@
 use core::cmp::min;
+use core::fmt;
+use core::fmt::Display;
+use core::fmt::Formatter;
 use core::ops::Add;
 
 use bitcoin::block::Header;
@@ -83,6 +86,16 @@ pub enum HeaderExtError {
     ChainWorkOverflow,
 }
 
+impl Display for HeaderExtError {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        match self {
+            HeaderExtError::Chain(e) => write!(f, "Chain error: {e}"),
+            HeaderExtError::BlockNotFound => write!(f, "Block not found"),
+            HeaderExtError::ChainWorkOverflow => write!(f, "Chain work overflow"),
+        }
+    }
+}
+
 impl HeaderExt for Header {
     fn calculate_median_time_past(
         &self,

crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs

@@ -8,6 +8,10 @@
 //! - Assumed valid blocks for validation optimization
 //! - UTREEXO accumulator state
 //! - Current chain tip and header
+use core::fmt;
+use core::fmt::Display;
+use core::fmt::Formatter;
+
 use bitcoin::block::Header as BlockHeader;
 use bitcoin::BlockHash;
 use bitcoin::Network;
@@ -39,6 +43,17 @@ pub enum BlockchainBuilderError {
     Database(Box<dyn DatabaseError>),
 }
 
+impl Display for BlockchainBuilderError {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        match self {
+            BlockchainBuilderError::MissingChainstore => write!(f, "Missing chainstore"),
+            BlockchainBuilderError::MissingChainParams => write!(f, "Missing chain parameters"),
+            BlockchainBuilderError::IncompleteTip => write!(f, "Incomplete tip"),
+            BlockchainBuilderError::Database(e) => write!(f, "Database error: {:?}", e),
+        }
+    }
+}
+
 #[derive(Clone, Debug, Default)]
 /// A builder for configuring and creating a `ChainState`.
 ///

crates/floresta-chain/src/pruned_utreexo/flat_chain_store.rs

@@ -69,6 +69,9 @@
 
 extern crate std;
 
+use core::fmt;
+use core::fmt::Display;
+use core::fmt::Formatter;
 use core::mem::size_of;
 use core::num::NonZeroUsize;
 use std::fs::DirBuilder;
@@ -382,6 +385,24 @@ pub enum FlatChainstoreError {
     InvalidValidationIndex,
 }
 
+impl Display for FlatChainstoreError {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        match self {
+            FlatChainstoreError::Io(e) => write!(f, "I/O error: {e}"),
+            FlatChainstoreError::BlockNotFound => write!(f, "Block not found"),
+            FlatChainstoreError::IndexIsFull => write!(f, "Index is full"),
+            FlatChainstoreError::DbTooNew(v) => write!(f, "Database too new: {v}"),
+            FlatChainstoreError::Poisoned => write!(f, "Poisoned"),
+            FlatChainstoreError::InvalidMagic(m) => write!(f, "Invalid magic: {m}"),
+            FlatChainstoreError::AccumulatorTooBig => write!(f, "Accumulator too big"),
+            FlatChainstoreError::IndexTooBig => write!(f, "Index too big"),
+            FlatChainstoreError::InvalidMetadataPointer => write!(f, "Invalid metadata pointer"),
+            FlatChainstoreError::DbCorrupted => write!(f, "Database corrupted"),
+            FlatChainstoreError::InvalidValidationIndex => write!(f, "Invalid validation index"),
+        }
+    }
+}
+
 /// Need this to use [FlatChainstoreError] as a [DatabaseError] in [ChainStore]
 impl DatabaseError for FlatChainstoreError {}
 

crates/floresta-chain/src/pruned_utreexo/udata.rs

@@ -179,6 +179,10 @@ impl Encodable for ScriptPubKeyKind {
 /// to consume a block (delete transactions included in it from the mempool);
 /// or to validate a block.
 pub mod proof_util {
+    use core::fmt;
+    use core::fmt::Display;
+    use core::fmt::Formatter;
+
     use bitcoin::blockdata::script;
     use bitcoin::blockdata::script::Instruction;
     use bitcoin::consensus::Encodable;
@@ -223,6 +227,16 @@ pub mod proof_util {
         NotPushBytes,
     }
 
+    impl Display for LeafErrorKind {
+        fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+            match self {
+                LeafErrorKind::EmptyStack => write!(f, "Empty stack"),
+                LeafErrorKind::InvalidInstruction(e) => write!(f, "Invalid instruction: {e}"),
+                LeafErrorKind::NotPushBytes => write!(f, "Not push bytes"),
+            }
+        }
+    }
+
     /// Error while reconstructing a leaf's scriptPubKey, returned by `process_proof`.
     ///
     /// This error is triggered if the input lacks the hashed data required by the

crates/floresta-node/src/slip132.rs

@@ -7,6 +7,9 @@
 //! Bitcoin SLIP-132 standard implementation for parsing custom xpub/xpriv key
 //! formats
 
+use core::fmt;
+use core::fmt::Display;
+use core::fmt::Formatter;
 use std::fmt::Debug;
 
 use bitcoin::base58;
@@ -108,6 +111,23 @@ pub enum Error {
     InternalFailure,
 }
 
+impl Display for Error {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        match self {
+            Error::Base58(e) => write!(f, "Base58 error: {e}"),
+            Error::Hex(e) => write!(f, "Hex error: {e}"),
+            Error::CannotDeriveFromHardenedKey => write!(f, "Cannot derive from hardened key"),
+            Error::InvalidChildNumber(n) => write!(f, "Invalid child number: {n}"),
+            Error::InvalidChildNumberFormat => write!(f, "Invalid child number format"),
+            Error::InvalidDerivationPathFormat => write!(f, "Invalid derivation path format"),
+            Error::UnknownVersion(v) => write!(f, "Unknown version: {:?}", v),
+            Error::WrongExtendedKeyLength(l) => write!(f, "Wrong extended key length: {l}"),
+            Error::UnknownSlip32Prefix => write!(f, "Unknown SLIP32 prefix"),
+            Error::InternalFailure => write!(f, "Internal failure"),
+        }
+    }
+}
+
 impl From<bip32::Error> for Error {
     fn from(err: bip32::Error) -> Self {
         match err {

crates/floresta-watch-only/src/memory_database.rs

@@ -3,6 +3,10 @@
 //! It's not meant to use in production, but for the integrated testing framework
 //!
 //! For actual databases that can be used for production code, see [KvDatabase](crate::kv_database::KvDatabase).
+use core::fmt;
+use core::fmt::Display;
+use core::fmt::Formatter;
+
 use bitcoin::hashes::sha256;
 use bitcoin::Txid;
 use floresta_common::prelude::sync::RwLock;
@@ -32,6 +36,14 @@ pub struct MemoryDatabase {
 
 type Result<T> = floresta_common::prelude::Result<T, MemoryDatabaseError>;
 
+impl Display for MemoryDatabaseError {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        match self {
+            MemoryDatabaseError::PoisonedLock => write!(f, "Poisoned lock"),
+        }
+    }
+}
+
 impl MemoryDatabase {
     fn get_inner(&self) -> Result<sync::RwLockReadGuard<'_, Inner>> {
         self.inner