Skip to content

Version 5.2.0 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 22, 2025
Merged

Version 5.2.0 #65

merged 10 commits into from
Jul 22, 2025

Conversation

Rangi42
Copy link
Collaborator

@Rangi42 Rangi42 commented Jun 30, 2025 •
edited
Loading

Fixes #67
Fixes #68

Whenever this is merged, update rgbds-live's js/gbz80.js tooltips accordingly.

@Rangi42 Rangi42 requested a review from avivace June 30, 2025 03:12
ISSOtm
ISSOtm reviewed Jul 1, 2025
View reviewed changes
@Rangi42 @ISSOtm
Update comment
ad04dce 
Co-authored-by: Eldred Habert <[email protected]>
@Rangi42 Rangi42 changed the title Changed _AUD3WAVERAM to AUD3WAVERAM Version 6.0 Jul 3, 2025
@Rangi42 Rangi42 requested a review from ISSOtm July 3, 2025 03:35
ISSOtm
ISSOtm approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Rangi42 Rangi42 marked this pull request as ready for review July 21, 2025 19:16
@Rangi42
Copy link
Collaborator Author

Rangi42 commented Jul 21, 2025

@avivace I still haven't found anything else to add/change here, so, ready for review!

avivace
avivace previously requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@avivace avivace left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the necessity of releasing another major right now. Hardware.inc is a project considered stable, solid and not this fast in breaking things. This should've been done in the previous major. I don't want additional effects coming from the premature merge of 5.0.

I'd suggest moving the non-breaking changes (so everything but AUD3WAVE_SIZE and AUD3WAVERAM related changes) to a normal patch or add the new AUD3WAVERAM but alias them to the old _AUD3WAVERAM versions so we don't have to break a major we literally released a couple of weeks ago.

@Rangi42
Copy link
Collaborator Author

Rangi42 commented Jul 22, 2025

No problem! I agree it's soon for another major. We can save the _-prefix fix for later.

@Rangi42 Rangi42 requested a review from avivace July 22, 2025 11:04
@Rangi42 Rangi42 changed the title Version 6.0 Version 5.2.0 Jul 22, 2025
@avivace avivace merged commit 1db4188 into gbdev:master Jul 22, 2025
2 checks passed
@Rangi42 Rangi42 deleted the next branch July 22, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add constants for the base addresses of all four audio channels Add constants for color shades
3 participants
@Rangi42 @avivace @ISSOtm