Skip to content

Set non-unique material to submesh when updating cast shadows property #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gz-sim10
Choose a base branch
from
Open

Set non-unique material to submesh when updating cast shadows property #3085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rendering/SceneManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,10 +396,10 @@ rendering::VisualPtr SceneManager::CreateVisual(Entity _id,
// unlike setting transparency above, the parent submesh are not
// notified about the the cast shadows changes. So we need to set
// the material back to the submesh.
// \todo(anyone) find way to propate cast shadows changes tos submesh
// \todo(anyone) find way to propagate cast shadows changes to submesh
// in gz-rendering
submeshMat->SetCastShadows(_visual.CastShadows());
submesh->SetMaterial(submeshMat);
submesh->SetMaterial(submeshMat, false);
}
}
}
Expand Down
Loading