Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions internal/database/subject.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ type Subject struct {
}

type SubjectFaculty struct {
ID string `gorm:"type:uuid;primaryKey"`
SubjectID string `gorm:"type:uuid;not null;index"`
FacultyID string `gorm:"type:uuid;not null"`
IsPrimary bool `gorm:"not null"`
ID string `gorm:"type:uuid;primaryKey"`
SubjectID string `gorm:"type:uuid;not null;index"`
FacultyID string `gorm:"type:uuid;not null"`
Faculty *Faculty `gorm:"foreignKey:FacultyID"`
IsPrimary bool `gorm:"not null"`
}

type SubjectEligibleAttribute struct {
Expand All @@ -48,7 +49,7 @@ func SubjectToDomain(m Subject) domain.Subject {
faculties := make([]domain.SubjectFaculty, len(m.Faculties))
for i, f := range m.Faculties {
faculties[i] = domain.SubjectFaculty{
FacultyID: f.FacultyID,
Faculty: FacultyToDomain(*f.Faculty),
IsPrimary: f.IsPrimary,
}
}
Expand Down Expand Up @@ -92,7 +93,7 @@ func SubjectFromDomain(d domain.Subject) Subject {
faculties := make([]SubjectFaculty, len(d.Faculties))
for i, f := range d.Faculties {
faculties[i] = SubjectFaculty{
FacultyID: f.FacultyID,
FacultyID: f.Faculty.ID,
IsPrimary: f.IsPrimary,
}
}
Expand Down
2 changes: 1 addition & 1 deletion internal/domain/subject.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package domain

type SubjectFaculty struct {
FacultyID string
Faculty Faculty
IsPrimary bool
}

Expand Down
6 changes: 2 additions & 4 deletions internal/handler/converter.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ func subjectToAPI(d domain.Subject) api.Subject {

faculties := make([]api.SubjectFaculty, len(d.Faculties))
for i, f := range d.Faculties {
// TODO: Faculty には Name, Email も必要。現状 domain.SubjectFaculty に情報がないため Id のみセットしている。
faculties[i] = api.SubjectFaculty{
Faculty: api.Faculty{Id: f.FacultyID},
Faculty: facultyToAPI(f.Faculty),
IsPrimary: f.IsPrimary,
}
}
Expand All @@ -54,9 +53,8 @@ func subjectToAPI(d domain.Subject) api.Subject {
func subjectToSummaryAPI(d domain.Subject) api.SubjectSummary {
faculties := make([]api.SubjectFaculty, len(d.Faculties))
for i, f := range d.Faculties {
// TODO: Faculty には Name, Email も必要。現状 domain.SubjectFaculty に情報がないため Id のみセットしている。
faculties[i] = api.SubjectFaculty{
Faculty: api.Faculty{Id: f.FacultyID},
Faculty: facultyToAPI(f.Faculty),
IsPrimary: f.IsPrimary,
}
}
Expand Down
2 changes: 1 addition & 1 deletion internal/repository/course_registration.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func NewCourseRegistrationRepository(db *gorm.DB) *CourseRegistrationRepository

func (r *CourseRegistrationRepository) courseRegistrationPreload(db *gorm.DB) *gorm.DB {
return db.
Preload("Subject.Faculties").
Preload("Subject.Faculties.Faculty").
Preload("Subject.EligibleAttributes").
Preload("Subject.Requirements")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/repository/subject.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func NewSubjectRepository(db *gorm.DB) *SubjectRepository {

func (r *SubjectRepository) subjectPreload(db *gorm.DB) *gorm.DB {
return db.
Preload("Faculties").
Preload("Faculties.Faculty").
Preload("EligibleAttributes").
Preload("Requirements")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/repository/timetable_items.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func NewTimetableItemRepository(db *gorm.DB) *TimetableItemRepository {

func (r *TimetableItemRepository) timetableItemPreload(db *gorm.DB) *gorm.DB {
return db.
Preload("Subject.Faculties").
Preload("Subject.Faculties.Faculty").
Preload("Subject.EligibleAttributes").
Preload("Subject.Requirements").
Preload("Rooms.Room")
Expand Down
Loading