Conversation
There was a problem hiding this comment.
Pull request overview
Subject が持つ Faculties 情報に、Faculty の詳細（id/name/email）を載せられるようにするための変更です。従来は SubjectFaculty に FacultyID しかなく API でも id のみ返していましたが、Faculty を関連として取得・変換する方向に寄せています。
Changes:
- SubjectFaculty（domain）を
FacultyIDからFaculty保持に変更 - DBモデル
SubjectFacultyにFaculty関連を追加し、取得時にFaculties.Facultyを preload - handler converter で
facultyToAPI(f.Faculty)を用いて Faculty 詳細を返すように変更
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/repository/subject.go | Subject 取得時の preload を Faculties.Faculty まで拡張 |
| internal/handler/converter.go | Subject/SubjectSummary の faculties 変換を Faculty 詳細返却に変更 |
| internal/domain/subject.go | SubjectFaculty が Faculty を内包する形に変更 |
| internal/database/subject.go | DBの SubjectFaculty に Faculty 関連を追加し、domain 変換も Faculty 詳細前提に変更 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
やったこと
確認したこと
メモ