Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest fqtk in DemuxFastqs #939

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Suggest fqtk in DemuxFastqs #939

merged 1 commit into from
Sep 26, 2023

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Sep 25, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2af51ac) 95.60% compared to head (ab7d03a) 95.60%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         126      126           
  Lines        7308     7308           
  Branches      487      487           
=======================================
  Hits         6987     6987           
  Misses        321      321           
Flag Coverage Δ
unittests 95.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../scala/com/fulcrumgenomics/fastq/DemuxFastqs.scala 96.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -202,6 +202,8 @@ object DemuxFastqs {
"""
|Performs sample demultiplexing on FASTQs.
|
|**Please see https://github.com/fulcrumgenomics/fqtk for a faster and supported replacement**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|**Please see https://github.com/fulcrumgenomics/fqtk for a faster and supported replacement**
|**Please use [`fqtk`](https://github.com/fulcrumgenomics/fqtk) for a faster and recommended alternative.**

@nh13 nh13 merged commit d748c76 into main Sep 26, 2023
4 checks passed
@nh13 nh13 deleted the nh13-patch-1 branch September 26, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants