Move the package to esm only #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the vaul package to ESM-only by removing CommonJS (CJS) build support and upgrading the bundler (bunchee) from version 5.x to 6.x.
- Upgrades bunchee from ^5.1.5 to ^6.6.2, which brings ESM-only build capabilities
- Removes CJS exports from package.json, keeping only ESM entry points
- Updates lock file with new dependencies for bunchee 6.x (nanospinner, tinyglobby) and removes ora-related dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/vaul/package.json | Updates package configuration to ESM-only by removing module, require exports, and CJS-related configuration; upgrades bunchee to 6.6.2 |
| pnpm-lock.yaml | Updates dependency tree with bunchee 6.6.2 and its new dependencies (@rollup/[email protected], nanospinner), removes ora and related packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closing for now, as we don't want breaking changes in the first release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops compiling the package to CJS. This was meant to be in 2.0 of #5, however, it's far easier to implement as ESM only than figuring how how to implement react-compiler with bunchee.