Update pull_request_template.md to include another test plan check #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional test plan check to manually verify the RPM is properly signed (in addition to seeing that CI is successful)
5 tasks
sssoleileraaa
force-pushed
the
update-pr-template
branch
from
aeda422 to
938120f
Compare
Signed-off-by: Allie Crevier <[email protected]>
sssoleileraaa
force-pushed
the
update-pr-template
branch
from
938120f to
d854445
Compare
ghost
self-requested a review
Merged
6 tasks
sssoleileraaa
commented
Jun 15, 2022
| > * Download the signed RPM from this PR | ||
| > * Run `rpm qi <signed-rpm>` to get the KEY ID | ||
| > * Run `gpg -k <KEY ID>` to verify that it matches the prod signing key (make sure you have the prod signing key referenced in the PR description in your GPG keyring) | ||
| - [ ] The Unsigned RPM checksum matches what's in the build logs |
There was a problem hiding this comment.
TODO: I need to update this to include a note about checking the checksum on an OS that matches the OS in which it was built. @L3th3 - any recommended details you think I should add about this?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional test plan check to manually verify the RPM is properly signed (in addition to seeing that CI is successful).