Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release qubes-template-securedrop-workstation (build tag: 0.3.0) #37

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Jul 1, 2022

Note that I am using a similar PR structure as we are aiming to introduce in the prod lfs repo (see freedomofpress/securedrop-yum-prod#31)

Description

Package being released: qubes-template-securedrop-workstation
Package tag: https://github.com/freedomofpress/qubes-template-securedrop-workstation/releases/tag/0.3.0
Build logs: freedomofpress/build-logs@cd13710 (note that I had to rebuild the template so it's easier to look at the files without the diff view: https://github.com/freedomofpress/build-logs/blob/cd137103c2af006692e7e65561473a49c706139e/workstation/qubes-template-securedrop-workstation-bullseye-4.0.6-202206302135/)
Test signing key used to sign package and tag: https://github.com/freedomofpress/securedrop-workstation-dev-rpm-packages-lfs/blob/HEAD/pubkeys/test.key

Release tracking issue: freedomofpress/securedrop-yum-prod#33

Checklist for PR owner

Checklist for reviewer

QA

Follow QA test plan in tracking issue

@sssoleileraaa sssoleileraaa changed the title 0.3.0 release Release qubes-template-securedrop-workstation (build tag: 0.3.0) Jul 1, 2022
@rocodes rocodes requested review from rocodes July 1, 2022 16:57
@rocodes
Copy link
Contributor

rocodes commented Jul 1, 2022

Notes: I installed this template manually by sticking it into dom0 and running sudo dnf install. I attempted to install via qvm-template install path/to/rpm, as the source code for that tool would seem to support, but encountered an error: ERROR: Signature Verification Failed: -: digests SIGNATURES NOT OK. [Edit for anyone trying to repro: I just realized maybe this is cause the signing key needs to also be in another directory besides /etc/pki/rpm-gpg/, istr keys in 2 locations in early 4.1 rcs. To revisit later.]
I had already verified in a fedora vm with the test key that the rpm was signed correctly and that the sha256sum of the file I was installing in dom0 matched the hash of the file in that vm, so I proceeded with the dnf install and it worked fine. Just a heads up to our future selves since I'm pretty sure dnf install (and dnf remove) are not recommended in 4.1.

Checklist for reviewer

QA

  • Template installs
  • Updater runs succesfully
  • Template and associated VMs are using 5.14.41-grsec-workstation kernel, 0.2.0 securedrop-workstation-config package, and pointing at apt repo
  • Client runs and basic client functionality is successful

Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comment - lgtm, thank you @creviera for putting all the pieces together <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants