Skip to content

fix(tests): use bare mktemp -d instead of hardcoded /tmp paths #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timothy-20 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): use bare mktemp -d instead of hardcoded /tmp paths #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/test_circuit_breaker_recovery.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ SCRIPT_DIR="${BATS_TEST_DIRNAME}/../../lib"

setup() {
# Create temp test directory
export TEST_TEMP_DIR="$(mktemp -d /tmp/ralph-cb-recovery.XXXXXX)"
export TEST_TEMP_DIR="$(mktemp -d)"
cd "$TEST_TEMP_DIR"

export RALPH_DIR=".ralph"
Expand Down Expand Up @@ -393,7 +393,7 @@ get_past_timestamp() {

# Create minimal environment for CLI parsing
local CLI_TEST_DIR
CLI_TEST_DIR="$(mktemp -d /tmp/ralph-cli-test.XXXXXX)"
CLI_TEST_DIR="$(mktemp -d)"
cd "$CLI_TEST_DIR"

git init > /dev/null 2>&1
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_exit_detection.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ setup() {
export MAX_CONSECUTIVE_DONE_SIGNALS=2

# Create temp test directory
export TEST_TEMP_DIR="$(mktemp -d /tmp/ralph-test.XXXXXX)"
export TEST_TEMP_DIR="$(mktemp -d)"
cd "$TEST_TEMP_DIR"
mkdir -p "$RALPH_DIR"

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_rate_limiting.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ setup() {
export TIMESTAMP_FILE="$RALPH_DIR/.last_reset"

# Create temp test directory
export TEST_TEMP_DIR="$(mktemp -d /tmp/ralph-test.XXXXXX)"
export TEST_TEMP_DIR="$(mktemp -d)"
cd "$TEST_TEMP_DIR"
mkdir -p "$RALPH_DIR"

Expand Down