fix(tests): use bare mktemp -d instead of hardcoded /tmp paths

[timothy-20]

Summary

Replace hardcoded /tmp paths in tests with bare mktemp -d for cross-platform portability.

Some test files used mktemp -d /tmp/ralph_test.XXXXXX which fails on systems where /tmp doesn't exist or is mounted differently (e.g., macOS uses /private/tmp). Using bare mktemp -d lets the OS choose the appropriate temporary directory.

Changes

• tests/unit/test_exit_detection.bats — remove /tmp prefix from mktemp
• tests/unit/test_rate_limiting.bats — remove /tmp prefix from mktemp
• tests/unit/test_edge_cases.bats — remove /tmp prefix from mktemp

Test plan

• All tests pass on Linux and macOS
• Temporary directories are created in OS-appropriate location

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Updated test infrastructure temporary directory handling across multiple test files for improved consistency in the testing framework.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff27b4 and 671f34f.

📒 Files selected for processing (3)

• tests/unit/test_circuit_breaker_recovery.bats
• tests/unit/test_exit_detection.bats
• tests/unit/test_rate_limiting.bats

---

Walkthrough

The pull request standardizes temporary directory creation across three test files by replacing explicit mktemp directory templates with generic mktemp -d invocations. Directory naming now defaults to the system's behavior rather than following predictable prefixed patterns, while all test functionality and logic remain unchanged.

Changes

Cohort / File(s)	Summary
Mktemp Template Standardization tests/unit/test_circuit_breaker_recovery.bats, tests/unit/test_exit_detection.bats, tests/unit/test_rate_limiting.bats	Replaced explicit mktemp directory templates (e.g., /tmp/ralph-cb-recovery.XXXXXX, /tmp/ralph-test.XXXXXX) with generic mktemp -d invocations in test setup routines, standardizing temporary directory creation across test files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• frankbria/ralph-claude-code#165: Directly related as it introduces the circuit-breaker recovery tests that are modified by this PR's mktemp standardization changes.

Poem

🐰 A bunny hops through test directories,
Where temporary homes once had fancy names,
Now mktemp -d keeps it simple, no fuss,
Same logic blooms, just with generic paths! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: replacing hardcoded /tmp paths with bare mktemp -d in test files, which is the core objective of this PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}