Razor inside html attribute #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
force-pushed
the
razor_inside_html_attribute
branch
from
6f1910e to
25ebfc4
Compare
Yes, this is suspicious.
michaelblyons
force-pushed
the
razor_inside_html_attribute
branch
from
ade6168 to
c3570b1
Compare
keith-hall
merged commit a5e0c0a
into
forkeith:razor_inside_html_attribute
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you rebase to
master, you'll get rid of the cruft. The big change here is popping 3 stack levels now to escape the C# contexts.I don't know if this is the shebang change or what, but I'm a little worried that something is very brittle.