Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

Purpose

Add subscribesTo to stripes.metadata to read the list of apps requiring a servicepoint from stripes, instead of using a hard-coded list.
Apps that rely on servicepoints should have "subscribesTo": ["servicepoints"] in package.json::stripes:

"stripes": {
  "subscribesTo": ["servicepoints"]
}

This will display the following modal if a servicepoint is missing:

image

Issues

https://folio-org.atlassian.net/browse/STRWEB-143

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team as a code owner January 7, 2026 15:35
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit d79551c. ± Comparison against base commit 0ef6273.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team January 7, 2026 15:37
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Which do you think is better:

  • copy only named properties of stripes into metadata, as we do here?
  • copy all stripes properties into metadata, naming a few properties to exclude (e.g. permissions and translations), so we don't have to update stripes-webpack just because we want to add a new property?

You could convince me either way.

@Dmytro-Melnyshyn
Copy link
Contributor Author

@zburke Metadata is a public API - new properties should be intentional, reviewed, and documented at least in a PR. Otherwise, every UI module can add whatever they deem necessary, which could lead to a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants