Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

Description

Previously, the service point modal window appeared for the app, because checking was added in https://github.com/folio-org/ui-servicepoints/blob/master/src/eventHandlers.js#L33. After changes were made in webpack and ui-sevicepoints, all the modules that need this modal should add "subscribesTo": ["servicepoints"] to package.json to replace the hard-coded list.

Screenshots

image

Approach

Refs

https://folio-org.atlassian.net/browse/UICHKIN-413

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

Jest Unit Test Results

  1 files  ±0   19 suites  ±0   18s ⏱️ ±0s
315 tests ±0  315 ✅ ±0  0 💤 ±0  0 ❌ ±0 
319 runs  ±0  319 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ba3b478. ± Comparison against base commit 3c2d96a.

@sonarqubecloud
Copy link

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team January 14, 2026 09:17
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 57c6a7b into master Jan 14, 2026
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UICHKIN-413 branch January 14, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants