Skip to content

fix(framework): Preserve output before runtime cleanup - #7921

Draft
tanertopal wants to merge 1 commit into
agent/shutdown-logging-executorsfrom
agent/shutdown-runtime-cleanup
Draft

fix(framework): Preserve output before runtime cleanup#7921
tanertopal wants to merge 1 commit into
agent/shutdown-logging-executorsfrom
agent/shutdown-runtime-cleanup

Conversation

@tanertopal

@tanertopal tanertopal commented Aug 18, 2026

Copy link
Copy Markdown
Member

What changed

  • allow an exit callback to run after callbacks that are already registered
  • register runtime-environment deletion as low-priority cleanup
  • preserve normal LIFO behavior for all other callbacks

Why

Runtime dependency installation registered filesystem cleanup after the executor output handler. LIFO execution could therefore delete the environment before final task status and context were reported.

Stack

Umbrella/reference: #7895 — Prevent task executor shutdown deadlock

Merge the stack in order. After the previous PR merges, retarget this PR to main.

Validation

  • pytest py/flwr/supercore/exit/exit_handler_test.py py/flwr/supercore/superexec/dependency_installer_test.py
  • Ruff and Black on the changed modules
  • git diff --check

@github-actions github-actions Bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Aug 18, 2026
@tanertopal
tanertopal force-pushed the agent/shutdown-logging-executors branch from 55ffc8d to 6b27f2a Compare August 18, 2026 16:11
@tanertopal
tanertopal force-pushed the agent/shutdown-runtime-cleanup branch from 15a2c89 to d26f847 Compare August 18, 2026 16:11
@tanertopal
tanertopal force-pushed the agent/shutdown-logging-executors branch from 6b27f2a to 38a2b0e Compare August 18, 2026 16:25
@tanertopal
tanertopal force-pushed the agent/shutdown-runtime-cleanup branch from d26f847 to cdbc04f Compare August 18, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant