fix(framework): Stop logging executors before completion - #7920
Draft
tanertopal wants to merge 1 commit into
Draft
fix(framework): Stop logging executors before completion#7920tanertopal wants to merge 1 commit into
tanertopal wants to merge 1 commit into
Conversation
This was referenced Aug 18, 2026
tanertopal
force-pushed
the
agent/shutdown-heartbeat-executors
branch
from
August 18, 2026 16:11
3e28fd0 to
36f20dd
Compare
tanertopal
force-pushed
the
agent/shutdown-logging-executors
branch
from
August 18, 2026 16:11
55ffc8d to
6b27f2a
Compare
tanertopal
force-pushed
the
agent/shutdown-heartbeat-executors
branch
from
August 18, 2026 16:25
36f20dd to
543df15
Compare
tanertopal
force-pushed
the
agent/shutdown-logging-executors
branch
from
August 18, 2026 16:25
6b27f2a to
38a2b0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
These executors have two authenticated background workers. Both must stop before task completion revokes the token, but their sequential cleanup must not consume the time reserved for final task output.
sequenceDiagram participant E as Executor participant H as Heartbeat worker participant L as Log uploader participant R as Runtime API E->>E: Disable retries E->>H: Stop E->>L: Drain and stop Note over H,L: Shared 2.5s cleanup deadline E->>R: PushTaskOutput with remaining deadline E->>E: Close transportStack
Umbrella/reference: #7895 — Prevent task executor shutdown deadlock
Merge the stack in order. After the previous PR merges, retarget this PR to
main.Validation
pytest py/flwr/superlink/runtime/run_serverapp_test.py py/flwr/simulation/app_test.pygit diff --check