Skip to content

gem: use latest net-http to solve IPv6 addr error #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

gem: use latest net-http to solve IPv6 addr error #5162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions fluentd.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency("strptime", [">= 0.2.4", "< 1.0.0"])
gem.add_runtime_dependency("webrick", ["~> 1.4"])
gem.add_runtime_dependency("zstd-ruby", ["~> 1.5"])
# uri v1.1.0 breaks the tests using IPv6 addresses.
# https://github.com/fluent/fluentd/issues/5141
gem.add_runtime_dependency("uri", ['~> 1.0', "< 1.1.0"])
gem.add_runtime_dependency("uri", '~> 1.0')
Copy link
Member

@ashie ashie Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gem.add_runtime_dependency("uri", '~> 1.0')

In my understanding it's introduced for this issue, originally we didn't limit the version uri gem.
Since net-http gem depends on it, we don't need specify the version of it.

Copy link
Contributor Author

@Watson1978 Watson1978 Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it introduced to address the warning message that URI::DEFAULT_PARSER outputs as obsolete.
#4774

gem.add_runtime_dependency("net-http", '~> 0.8')
gem.add_runtime_dependency("async-http", "~> 0.86")

# gems that aren't default gems as of Ruby 3.4
Expand Down