gem: use latest net-http to solve IPv6 addr error #5162
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shizuo Fujita <[email protected]>
Watson1978
added
the
backport to v1.19
ashie
requested changes
Nov 21, 2025
| # uri v1.1.0 breaks the tests using IPv6 addresses. | ||
| # https://github.com/fluent/fluentd/issues/5141 | ||
| gem.add_runtime_dependency("uri", ['~> 1.0', "< 1.1.0"]) | ||
| gem.add_runtime_dependency("uri", '~> 1.0') |
Member
There was a problem hiding this comment.
Suggested change
| gem.add_runtime_dependency("uri", '~> 1.0') |
In my understanding it's introduced for this issue, originally we didn't limit the version uri gem.
Since net-http gem depends on it, we don't need specify the version of it.
Contributor
Author
There was a problem hiding this comment.
it introduced to address the warning message that URI::DEFAULT_PARSER outputs as obsolete.
#4774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #5141
What this PR does / why we need it:
net-httphad a bug in handling IPv6 addresses, and updating theuriwould trigger strict checking, causing errors.This PR will use
net-httpthat has the bug fixed.Docs Changes:
N/A
Release Note:
gem: use latest net-http to solve IPv6 addr error