Skip to content

refactor(cli): use child process to avoid self-update issues #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cabljac wants to merge 1 commit into from
Closed

refactor(cli): use child process to avoid self-update issues #3406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions genkit-tools/cli/src/commands/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,42 @@ async function downloadAndInstall(
}

logger.info('Running using npm, downloading using npm...');
execSync(command);
logger.info(
`${clc.green('✓')} Successfully updated to ${clc.bold(version)}`
);

try {
// Use child process to avoid self-updating issues
execSync(command, {
stdio: 'inherit', // Show npm output to user
timeout: 300000, // 5 minute timeout
});
logger.info(
`${clc.green('✓')} Successfully updated to ${clc.bold(version)}`
);
} catch (error: any) {
// Handle npm installation errors gracefully
if (error.status === 1) {
logger.error(
`${clc.red('npm installation failed:')} The command '${command}' exited with code 1.`
);
logger.info(
`${clc.dim('Try running the command manually:')} ${clc.bold(command)}`
);
process.exit(1);
} else if (error.signal === 'SIGTERM') {
logger.error(
`${clc.red('npm installation timed out:')} The installation took longer than 5 minutes.`
);
logger.info(
`${clc.dim('Try running the command manually:')} ${clc.bold(command)}`
);
process.exit(1);
} else {
logger.error(`${clc.red('npm installation failed:')} ${error.message}`);
logger.info(
`${clc.dim('Try running the command manually:')} ${clc.bold(command)}`
);
process.exit(1);
}
}
return;
}

Expand Down
Loading