-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for emulator import/export in VSCode #8053
Open
joehan
wants to merge
41
commits into
master
Choose a base branch
from
jh-import-export-vsce
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
26241ce
Added config
joehan 094164a
Merge remote-tracking branch 'public/master' into jh-persistence-prot…
joehan 6e03ec1
Adding basic persistence support
joehan 6c9834d
formats
joehan 872b150
Merge branch 'master' into jh-persistence-prototype
joehan d8355f3
Merge remote-tracking branch 'public/master' into jh-persistence-prot…
joehan 31560d9
Starting on clearData
joehan 84074cf
Merge remote-tracking branch 'public/master' into jh-persistence-prot…
joehan f510a73
Clear data now working!
joehan 5d046cf
Added import/export support
joehan 79f651c
Merge branch 'master' into jh-persistence-prototype
joehan 1a13dfa
PR fixes + fidelity to approved API'
joehan 9c9e139
Merge branch 'jh-persistence-prototype' of github.com:firebase/fireba…
joehan 8b56148
Merging master
joehan 0fe172f
Trying to fix vsce compile
joehan 45fdcc2
Merge branch 'master' into jh-persistence-prototype
joehan 6aa6e98
Progress on vsce import/export/clearData UI
joehan c6f7ada
fixed build issue
joehan b5b7d2b
Merge remote-tracking branch 'public/master' into jh-import-export-vsce
joehan ba3c83d
Merge remote-tracking branch 'public/master' into jh-import-export-vsce
joehan 4a73f32
Merge remote-tracking branch 'public/master' into jh-import-export-vsce
joehan 4f725b6
Adding config options for importPath/exportPath/exportOnExit
joehan 50a10a8
More fixes
joehan cc4680e
add changelog
joehan 69169ec
Merge conflict
joehan 545557c
Tweak the emulator action-buttons
tjlav5 7f8800f
Startign on tests
joehan 9f41ee8
Merging master
joehan 4b5d2c6
Merge branch 'jh-import-export-vsce' of github.com:firebase/firebase-…
joehan ef1dd31
Adding basic tests for export and clear'
joehan a4fef1c
Merge branch 'master' into jh-import-export-vsce
joehan 76f7707
format
joehan 7688793
ajv upgrade
joehan 5bd2ab3
Merge branch 'master' into jh-import-export-vsce
joehan 75c2f5e
Merge branch 'master' into jh-import-export-vsce
joehan 2bfaadb
Fix config issue
joehan c17e921
Fix typo
joehan 83d6524
Santiy checking terminalView - does this even resolve?
joehan e962c12
Merge branch 'master' into jh-import-export-vsce
joehan 4fe94da
Does it work as a single test?
joehan 3350cc8
PR fixes
joehan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"projects": { | ||
"default": "dart-firebase-admin" | ||
"default": "test-project" | ||
}, | ||
"targets": {}, | ||
"etags": {}, | ||
|
13 changes: 13 additions & 0 deletions
13
firebase-vscode/src/test/utils/page_objects/notifications.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Workbench } from "wdio-vscode-service"; | ||
|
||
export class Notifications { | ||
constructor(readonly workbench: Workbench) {} | ||
|
||
async getExportNotification() { | ||
const notifications = await this.workbench.getNotifications(); | ||
return notifications.find(async n => { | ||
const message = await n.getMessage(); | ||
return message.includes("Emulator Data exported to"); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { Workbench } from "wdio-vscode-service"; | ||
|
||
export class TerminalView { | ||
constructor(readonly workbench: Workbench) {} | ||
|
||
private readonly bottomBar = this.workbench.getBottomBar(); | ||
async getTerminalText() { | ||
const tv = await this.bottomBar.openTerminalView(); | ||
return tv.getText(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: these are very simple so it's ok; but prefer named function OR comments describing these; Otherwise sifting through subscriptions gets difficult