Add support for emulator import/export in VSCode #8053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-tools into jh-persistence-prototype
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8053 +/- ##
==========================================
- Coverage 51.14% 51.11% -0.03%
==========================================
Files 423 423
Lines 29581 29604 +23
Branches 6043 6049 +6
==========================================
+ Hits 15128 15133 +5
- Misses 13094 13112 +18
Partials 1359 1359 ☔ View full report in Codecov by Sentry. |
|
@hlshen I added some basic tests here but I;m having trouble getting the existing tests to pass locally for me. When you're back, could you sanity check me on how these were implemented and help me get them up to standard? |
hlshen
reviewed
Jan 16, 2025
hlshen
reviewed
Jan 16, 2025
hlshen
reviewed
Jan 16, 2025
| @@ -21,6 +22,24 @@ export class EmulatorsController implements Disposable { | |||
| this.setEmulatorsStarting(); | |||
| }), | |||
| ); | |||
|
|
|||
| this.subscriptions.push( | |||
There was a problem hiding this comment.
nit: these are very simple so it's ok; but prefer named function OR comments describing these; Otherwise sifting through subscriptions gets difficult
hlshen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for emulator import and export in VSCode.
TODO:
Scenarios Tested
I tested out all the basic CUJs here - export button triggers an export, clear data clears the data, and each of the settings work.