Skip to content

Remove window requirement from remote-config #8785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove window requirement from remote-config #8785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e34bd6
Remove window requirement from remot-config
spookyuser Feb 11, 2025
440fabd
Merge branch 'main' into fix-remote-config-window
spookyuser Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/remote-config/src/client/rest_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ export class RestClient implements RemoteConfigFetchClient {
this.firebaseInstallations.getToken()
]);

const urlBase =
window.FIREBASE_REMOTE_CONFIG_URL_BASE ||
'https://firebaseremoteconfig.googleapis.com';
let urlBase = 'https://firebaseremoteconfig.googleapis.com';
if (typeof window!== 'undefined' && window.FIREBASE_REMOTE_CONFIG_URL_BASE) {
urlBase = window.FIREBASE_REMOTE_CONFIG_URL_BASE;
}

const url = `${urlBase}/v1/projects/${this.projectId}/namespaces/${this.namespace}:fetch?key=${this.apiKey}`;

Expand Down
4 changes: 4 additions & 0 deletions packages/remote-config/src/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ export function registerRemoteConfig(): void {
.getProvider('installations-internal')
.getImmediate();

// Guards against the SDK being used when indexedDB is not available.
if (!isIndexedDBAvailable()) {
throw ERROR_FACTORY.create(ErrorCode.INDEXED_DB_UNAVAILABLE);
}
// Normalizes optional inputs.
const { projectId, apiKey, appId } = app.options;
if (!projectId) {
Expand Down