You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per #2242 firebase remote config will throw an error in any environment without a window variable.
The only reason for requiring the window variable seems to be setting the window.FIREBASE_REMOTE_CONFIG_URL_BASE
With a very slight tweak, we can make remote config run in contexts like chrome extension service workers which don't have the window variable but do work fine with remote config in every other respect and moreover where remote config proves to be especially useful, given the time it takes to roll out extension updates.
[citation: am currently using it in service worker with this patch and it works great]
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
As per #2242 firebase remote config will throw an error in any environment without a window variable.
The only reason for requiring the window variable seems to be setting the
window.FIREBASE_REMOTE_CONFIG_URL_BASEWith a very slight tweak, we can make remote config run in contexts like chrome extension service workers which don't have the window variable but do work fine with remote config in every other respect and moreover where remote config proves to be especially useful, given the time it takes to roll out extension updates.
[citation: am currently using it in service worker with this patch and it works great]