Remove window requirement from remote-config #8785
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
As per #2242 firebase remote config will throw an error in any environment without a window variable.
The only reason for requiring the window variable seems to be setting the
window.FIREBASE_REMOTE_CONFIG_URL_BASE
With a very slight tweak, we can make remote config run in contexts like chrome extension service workers which don't have the window variable but do work fine with remote config in every other respect and moreover where remote config proves to be especially useful, given the time it takes to roll out extension updates.
[citation: am currently using it in service worker with this patch and it works great]