Skip to content

Remove window requirement from remote-config #8785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

spookyuser
Copy link

Discussion

As per #2242 firebase remote config will throw an error in any environment without a window variable.

The only reason for requiring the window variable seems to be setting the window.FIREBASE_REMOTE_CONFIG_URL_BASE

With a very slight tweak, we can make remote config run in contexts like chrome extension service workers which don't have the window variable but do work fine with remote config in every other respect and moreover where remote config proves to be especially useful, given the time it takes to roll out extension updates.

[citation: am currently using it in service worker with this patch and it works great]

@spookyuser spookyuser requested review from erikeldridge and a team as code owners February 11, 2025 19:12
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 440fabd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

google-cla bot commented Feb 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@spookyuser
Copy link
Author

Seems like this was fixed yesterday by #8699 thanks so much!

@spookyuser spookyuser closed this Feb 12, 2025
@spookyuser spookyuser deleted the fix-remote-config-window branch February 12, 2025 12:28
@firebase firebase locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant