Emulator Idempotency: Firestore #8780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertex AI Mock Responses Check
|
|
DellaBitta
changed the title
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
This was referenced Feb 10, 2025
dlarocque
approved these changes
Feb 11, 2025
| @@ -494,4 +494,5 @@ export class WriteBatch { | |||
| // @public | |||
| export function writeBatch(firestore: Firestore): WriteBatch; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
i did not see this API proposal 😮
There was a problem hiding this comment.
It was a blank document. :)
MarkDuckworth
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
LGTM. However, the description says this fixes #6824, but that is related to Auth. Not a big deal because you're apply this to auth at the same time, but in a different PR.
Righto, removed that Fixes comment in the PR. Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Update
connectFirestoreEmulatorto support its invocation more than once. If the Firestore instance is already in use, andconnectFirestoreEmulatoris invoked with the same configuration, then the invocation will now succeed instead of assert.The implementation takes the Data Connect implementation as inspiration. Data Connect stores the parameters passed to
connectDataConnectEmulatoron the instance of Data Connect itself, so that they can be quickly checked to see if subsequent invocations match. This PR implements a similar storage and compare process with the optionalemulatorOptionsparameter (host and port are already stored).This PR unlocks support for SSR frameworks which render the page numerous times with the same instances of Firestore. Before this PR customers were required to guard against calling
connectFirestoreEmulatorin their SSR logic, which added to code complexity. Now the Firebase SDK does that guarding logic so that our users' apps don't have to.Testing
CI, new tests added to
packages/firestore/test/integration/api/validation.test.tsandpackages/firestore/test/unit/api/database.test.ts.API Changes
N/A