Emulator Idempotency: Database #8769
Merged
+73
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7bfbec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (172,033 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
changed the title
DellaBitta
requested review from
a team,
maneesht and
aashishpatil-g
as code owners
dlarocque
approved these changes
Feb 7, 2025
hsubox76
approved these changes
Feb 10, 2025
| @@ -138,6 +141,43 @@ describe('Database@exp Tests', () => { | |||
| unsubscribe(); | |||
| }); | |||
|
|
|||
| it('can connected to emulator', async () => { | |||
There was a problem hiding this comment.
Nit: some typos. "can connected to" here and in 160, "chnage" in 151
maneesht
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Update the
connectDatabaseEmulatorfunction to support its invocation more than once. If the Database instance is already in use, andconnectDatabaseEmulatoris invoked with the same configuration, then the invocation will now succeed instead of assert.This unlocks support for web frameworks which may render the page numerous times with the same instances of RTDB. Before this PR customers needed to add extra code to guard against calling
connectDatabaseEmulatorin their SSR logic. Now we do that guarding logic on their behalf which should simplify our customer's apps.Fixes #6824.
Testing
CI, new tests added to integration tests.
API Changes
N/A