-
Notifications
You must be signed in to change notification settings - Fork 417
fix(firestore-bigquery-export): Add Backward Compatibility and New Event Types for Firestore BigQuery Export #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cabljac
merged 1 commit into
next
from
@invertase/Extensions/firestore-bigquery-export/1981
Jan 31, 2025
Merged
fix(firestore-bigquery-export): Add Backward Compatibility and New Event Types for Firestore BigQuery Export #2244
cabljac
merged 1 commit into
next
from
@invertase/Extensions/firestore-bigquery-export/1981
Jan 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa614f5
to
925668e
Compare
cabljac
reviewed
Dec 23, 2024
cabljac
reviewed
Dec 23, 2024
cabljac
reviewed
Dec 23, 2024
pr-Mais
reviewed
Dec 23, 2024
9ddae40
to
3fcac8e
Compare
pr-Mais
previously requested changes
Dec 30, 2024
15cc2b0
to
26951aa
Compare
26951aa
to
baab3d3
Compare
@cabljac Do you have any final comments regarding this? |
Changes applied in the last ammend
cabljac
approved these changes
Jan 31, 2025
dd73667
to
d56e77b
Compare
d56e77b
to
7a34ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
extension: firestore-bigquery-export
Related to firestore-bigquery-export extension
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1981
Description (issue 1981):
This PR introduces backward-compatible event types while adding new naming conventions for Firestore BigQuery Export. The changes ensure robust event handling across multiple versions of the extension. The following updates have been made:
Key Changes:
1. New Event Types:
• Introduced new events using the updated naming convention:
• firebase.extensions.firestore-bigquery-export.v1.onStart
• firebase.extensions.firestore-bigquery-export.v1.onSuccess
• firebase.extensions.firestore-bigquery-export.v1.onError
• firebase.extensions.firestore-bigquery-export.v1.onCompletion
2. Backward Compatibility:
• Maintains the existing events under the old naming convention:
• firebase.extensions.firestore-counter.v1.*
• Both old and new event types are published for each operation to ensure smooth migration.
3. Refactored Event Publishing:
• Updated event publishing logic to dynamically handle both old and new event types.
• Functions now publish events using Promise.all for better concurrency.
4. Unit Tests:
• Enhanced unit tests to verify:
• Events for both old and new naming conventions are correctly published.
• Proper handling of CREATE, DELETE, and UPDATE scenarios.
• Mocked Eventarc interactions for improved testing reliability.
5. Code Improvements:
• Refactored events.ts to dynamically generate both old and new event types for reuse.
• Added extensive documentation to clarify the event publishing logic and backward compatibility strategy.