fix(firestore-bigquery-export): update event types for Eventarc compa…

…tibility (#1981)
firebase · Dec 20, 2024 · aa614f5 · aa614f5
1 parent 5a9311b
commit aa614f5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/firestore-bigquery-export/functions/src/events.ts b/firestore-bigquery-export/functions/src/events.ts
@@ -49,7 +49,7 @@ export const setupEventChannel = () => {
  * @returns A Promise resolving when both events are published.
  */
 export const recordStartEvent = async (data: string | object) => {
-  if (!eventChannel) return;
+  if (!eventChannel) return Promise.resolve(); // Explicitly return a resolved Promise
 
   const eventTypes = getEventTypes("onStart");
 
@@ -72,7 +72,7 @@ export const recordStartEvent = async (data: string | object) => {
  * @returns A Promise resolving when both events are published.
  */
 export const recordErrorEvent = async (err: Error, subject?: string) => {
-  if (!eventChannel) return;
+  if (!eventChannel) return Promise.resolve(); // Ensure consistent return type
 
   const eventTypes = getEventTypes("onError");
 
@@ -103,7 +103,7 @@ export const recordSuccessEvent = async ({
   subject: string;
   data: string | object;
 }) => {
-  if (!eventChannel) return;
+  if (!eventChannel) return Promise.resolve(); // Explicitly return a resolved Promise
 
   const eventTypes = getEventTypes("onSuccess");
 
@@ -126,7 +126,7 @@ export const recordSuccessEvent = async ({
  * @returns A Promise resolving when both events are published.
  */
 export const recordCompletionEvent = async (data: string | object) => {
-  if (!eventChannel) return;
+  if (!eventChannel) return Promise.resolve(); // Ensure consistent return type
 
   const eventTypes = getEventTypes("onCompletion");