Skip to content

exclude .inc files #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,34 @@ let package = Package(
"absl/base/spinlock_test_common.cc",
"absl/base/internal/exception_safety_testing.cc",
"absl/random/benchmarks.cc",
// .inc files
"absl/debugging/internal/stacktrace_win32-inl.inc",
"absl/debugging/internal/stacktrace_riscv-inl.inc",
"absl/debugging/internal/stacktrace_generic-inl.inc",
"absl/debugging/internal/stacktrace_unimplemented-inl.inc",
"absl/debugging/internal/stacktrace_x86-inl.inc",
"absl/debugging/internal/stacktrace_arm-inl.inc",
"absl/debugging/internal/stacktrace_aarch64-inl.inc",
"absl/debugging/internal/stacktrace_powerpc-inl.inc",
"absl/debugging/internal/stacktrace_emscripten-inl.inc",
"absl/debugging/symbolize_win32.inc",
"absl/debugging/symbolize_emscripten.inc",
"absl/debugging/symbolize_unimplemented.inc",
"absl/debugging/symbolize_elf.inc",
"absl/debugging/symbolize_darwin.inc",
"absl/time/internal/get_current_time_chrono.inc",
"absl/time/internal/get_current_time_posix.inc",
"absl/numeric/int128_have_intrinsic.inc",
"absl/numeric/int128_no_intrinsic.inc",
"absl/log/log_basic_test_impl.inc",
"absl/log/check_test_impl.inc",
"absl/base/internal/spinlock_akaros.inc",
"absl/base/internal/spinlock_linux.inc",
"absl/base/internal/spinlock_posix.inc",
"absl/base/internal/spinlock_win32.inc",
// other files
"absl/flags/flag_benchmark.lds",
"absl/abseil.podspec.gen.py",
],
sources: [
"absl/"
Expand Down
3 changes: 2 additions & 1 deletion SwiftPMTests/build-test/test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@
#include "absl/types/variant.h"

// Test for duplicate `_main` symbol.
int main(int argc, char** argv) {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the following error:

% swift test
Building for debugging...
error: link command failed with exit code 1 (use -v to see invocation)
duplicate symbol '_main' in:
    /Users/hannahshi/work/abseil-cpp-SwiftPM/.build/arm64-apple-macosx/debug/build_test.build/test.cc.o
    /Users/hannahshi/work/abseil-cpp-SwiftPM/.build/arm64-apple-macosx/debug/abseilPackageTests.build/runner.swift.o
ld: 1 duplicate symbols
clang: error: linker command failed with exit code 1 (use -v to see invocation)

// _main is defined in runner.swift, any other definition of `_main` in abseil
// files will cause a duplicate symbol error.