Skip to content

exclude .inc files #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HannahShiSFB
Copy link
Collaborator

@HannahShiSFB HannahShiSFB commented Apr 1, 2025

inc files causing wmodules-import-nested-redundant error, this is an attempt to avoid the issue.

ref: abseil/abseil-cpp#1861

Tested with

swift build
swift test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@@ -48,4 +48,5 @@
#include "absl/types/variant.h"

// Test for duplicate `_main` symbol.
int main(int argc, char** argv) {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the following error:

% swift test
Building for debugging...
error: link command failed with exit code 1 (use -v to see invocation)
duplicate symbol '_main' in:
    /Users/hannahshi/work/abseil-cpp-SwiftPM/.build/arm64-apple-macosx/debug/build_test.build/test.cc.o
    /Users/hannahshi/work/abseil-cpp-SwiftPM/.build/arm64-apple-macosx/debug/abseilPackageTests.build/runner.swift.o
ld: 1 duplicate symbols
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@HannahShiSFB HannahShiSFB requested a review from paulb777 April 19, 2025 18:11
@paulb777 paulb777 closed this Apr 19, 2025
@paulb777 paulb777 reopened this Apr 19, 2025
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I reenabled the expired CI. LGTM on green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants