-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented search and pagination in Dashboard #804
Conversation
darkhorse-420
commented
Nov 15, 2024
•
edited
Loading
edited
added it to repository as well
code clean
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Again would love to see this merged (or we'll have to implement it). It looks like it builds on and supersedes #783 which should close. Having compared the PRs (almost line-by-line) I can see that this PR contains all the main changes from #783 and adds filtering on the dashboard - so it is the version that should proceed. |
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
@kriswest - merge conflicts are resolved 👍 Waiting for the full build and then will merge into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 49 49
Lines 1805 1805
=======================================
Hits 1117 1117
Misses 688 688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰