Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented search and pagination in Dashboard #804

Merged
merged 29 commits into from
Mar 25, 2025

Conversation

darkhorse-420
Copy link
Contributor

@darkhorse-420 darkhorse-420 commented Nov 15, 2024

Screenshot 2024-11-16 at 12 10 24 AM

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 03f0dba
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6737931c46e35c00089b0b37

@darkhorse-420 darkhorse-420 changed the title Search feat : Implemented search and pagination in Dashboard Nov 15, 2024
@kriswest
Copy link

Again would love to see this merged (or we'll have to implement it). It looks like it builds on and supersedes #783 which should close. Having compared the PRs (almost line-by-line) I can see that this PR contains all the main changes from #783 and adds filtering on the dashboard - so it is the version that should proceed.

@JamieSlome

@JamieSlome JamieSlome changed the title feat : Implemented search and pagination in Dashboard feat: Implemented search and pagination in Dashboard Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 06d7042
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/67e28567d247f90008d23aa5

@JamieSlome
Copy link
Member

@kriswest - merge conflicts are resolved 👍 Waiting for the full build and then will merge into main + release 🚀

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.88%. Comparing base (d6d93e0) to head (06d7042).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files          49       49           
  Lines        1805     1805           
=======================================
  Hits         1117     1117           
  Misses        688      688           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome enabled auto-merge March 25, 2025 10:29
@JamieSlome JamieSlome merged commit ec00db2 into finos:main Mar 25, 2025
12 checks passed
@JamieSlome JamieSlome linked an issue Mar 25, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement search, pagination, filtering and ordering in UI
3 participants