Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pagination and search component #783

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

darkhorse-420
Copy link

added pagination and search to /Repositories and /Users

Copy link

linux-foundation-easycla bot commented Nov 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit e8d8ba7
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6732416847541900084fa4d2

@laukik-target
Copy link
Contributor

Testing Results:

  1. This placement can it be done better? Maybe symmetric and think of a consistent design/color scheme
    image

  2. Pagination is working fine and Searching is working fine but to search, we have to type and then hit enter. Can we make it efficient by implementing search as you type, I mean "real-time search" or "instant search."

@JamieSlome
Copy link
Member

Great pull request 👍 Is there any chance we could add search on the dashboard page as well for searching pushes and commits?

@darkhorse-420
Copy link
Author

yes will do that @JamieSlome .

@darkhorse-420
Copy link
Author

alright, thanks for the suggestions @laukik-target , will incorporate the same.

@darkhorse-420
Copy link
Author

Great pull request 👍 Is there any chance we could add search on the dashboard page as well for searching pushes and commits?

what is the format of data that is expected in pushes.db? i wanted to test my code for the dashboard page.

@darkhorse-420
Copy link
Author

☝🏻Modified the UI of search bar and added real-time search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants