Skip to content

design: CheckboxButton, TextField 디자인 수정#53

Merged
wlrnjs merged 3 commits into
developfrom
design/check-box-text-field
May 15, 2026
Merged

design: CheckboxButton, TextField 디자인 수정#53
wlrnjs merged 3 commits into
developfrom
design/check-box-text-field

Conversation

@wlrnjs
Copy link
Copy Markdown
Member

@wlrnjs wlrnjs commented May 13, 2026

Pull Request

관련 이슈

  • close #이슈번호

작업 내용

  • CheckboxButton, TextField 컴포넌트의 디자인을 피그마 시안에 맞게 수정했습니다.

참고 사항

  • 기능 변경은 없으며, 디자인만 수정한 PR입니다.
  • 디자인 토큰 관련 브랜치에서 이어서 작업한 브랜치라 파일 변경이 많이 표시됩니다.
  • 이전 PR 머지 후 리뷰해 주시면 됩니다.

체크리스트

  • 기능이 정상 동작하는지 확인
  • 불필요한 코드/주석 제거

@wlrnjs wlrnjs requested a review from junye0l May 13, 2026 05:59
@wlrnjs wlrnjs self-assigned this May 13, 2026
@wlrnjs wlrnjs added D-3 3일 이내에 처리가 필요합니다. design CSS, 레이아웃, 반응형, 퍼블리싱 관련 수정 labels May 13, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment May 14, 2026 1:32am

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on aligning the CheckboxButton and TextField components with the latest design system specifications. It introduces a new design token package, updates the global CSS and Tailwind configuration to support these tokens, and cleans up the Dashboard page by removing deprecated mock data queries.

Highlights

  • Design System Integration: Integrated @infra-support/design-tokens into the project, updating Tailwind configuration and CSS imports to utilize the new design system tokens.
  • Component Styling Updates: Refactored CheckboxButton and TextField components to align with the latest Figma design specifications, including updated spacing, sizing, and state styling.
  • Build System Improvements: Enhanced the Style Dictionary configuration to better handle semantic tokens and automated file header generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


Tokens defined in a neat little row, / Making our components start to glow. / From text fields to buttons, the design is now tight, / Everything rendered in the perfect light.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates a design token system into the monitor-web application, involving updates to the Tailwind configuration, Style Dictionary build scripts, and core UI components. The CheckboxButton and TextField components were refactored to use semantic tokens for colors, spacing, and typography. Review feedback identifies a potential readability issue where line height is smaller than font size in new text utilities, suggests improving the visual feedback for input states, and recommends applying the disabled cursor to the entire checkbox button rather than just the icon.

Comment thread apps/monitor-web/src/utils/tailwind.plugins.ts
Comment thread apps/monitor-web/src/components/common/inputs/TextField.tsx
Comment thread apps/monitor-web/src/components/common/buttons/CheckboxButton.tsx
Copy link
Copy Markdown
Member

@junye0l junye0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@wlrnjs wlrnjs merged commit 8bd11e4 into develop May 15, 2026
3 checks passed
@wlrnjs wlrnjs deleted the design/check-box-text-field branch May 15, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-3 3일 이내에 처리가 필요합니다. design CSS, 레이아웃, 반응형, 퍼블리싱 관련 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants