feat: 디자인 토큰 파이프라인 구축#52
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 디자인 시스템의 일관성을 유지하기 위해 디자인 토큰 파이프라인을 구축하는 작업을 포함합니다. Tokens Studio for Figma에서 추출한 디자인 토큰을 기반으로 Style Dictionary를 통해 웹 환경에서 즉시 사용 가능한 CSS 변수와 Tailwind 프리셋을 자동 생성하도록 설계되었습니다. 이를 통해 디자인 변경 사항을 코드에 효율적으로 반영할 수 있는 기반을 마련했습니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. 토큰이 모여 디자인을 이루고, 파이프라인은 코드를 잇네. 수동의 굴레를 벗어던지고, 일관된 스타일이 흐르네. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates a design token system into the monitor-web application, including updates to the Style Dictionary configuration and the addition of a Tailwind preset. Key feedback includes addressing a bug in the token generation logic where only [Fill] semantic tokens are currently processed, potentially omitting [Fg] and [Border] types. Additionally, it is recommended to move hardcoded typography styles from the Tailwind plugin into the design tokens package to ensure system-wide consistency and better alignment with Tailwind's utility-first approach.
Pull Request
관련 이슈
작업 내용
packages/design-tokens에 디자인 토큰 전용 패키지를 구성했습니다.tokens/tokens.json: Tokens Studio for Figma 디자인 토큰 원본sd.config.mjs: Style Dictionary 빌드 설정dist/css/variables.css: CSS 커스텀 프로퍼티dist/tailwind/preset.cjs: Tailwind preset 객체apps/monitor-web/tailwind.config.ts: 디자인 토큰 preset 적용presset: [designTokensPreset]참고 사항
variables.css,preset.cjs파일은 디자인 토큰 빌드를 통해 자동 생성되는 산출물 입니다.체크리스트