Skip to content

feat: 디자인 토큰 자동화 테스트#47

Merged
wlrnjs merged 1 commit into
developfrom
design-tokens
May 11, 2026
Merged

feat: 디자인 토큰 자동화 테스트#47
wlrnjs merged 1 commit into
developfrom
design-tokens

Conversation

@wlrnjs
Copy link
Copy Markdown
Member

@wlrnjs wlrnjs commented May 11, 2026

Pull Request

관련 이슈

작업 내용

  • Tokens Studio for Figma에서 발생한 커밋을 develop으로 올리는 PR입니다

참고 사항

체크리스트

  • 기능이 정상 동작하는지 확인
  • 불필요한 코드/주석 제거

@wlrnjs wlrnjs requested a review from junye0l May 11, 2026 16:30
@wlrnjs wlrnjs self-assigned this May 11, 2026
@wlrnjs wlrnjs added D-0 12시간 이내에 처리가 필요합니다. chore 의존성 업데이트, 환경 세팅, 빌드 설정 등 유지보수 작업 labels May 11, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment May 11, 2026 4:30pm

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Tokens Studio for Figma를 통해 관리되는 디자인 토큰을 프로젝트에 동기화하는 작업입니다. 이번 변경을 통해 디자인 시스템의 원시(Primitive) 값과 의미론적(Semantic) 토큰 구조가 대폭 확장되어, 향후 디자인 시스템의 일관된 적용과 자동화된 관리가 가능해졌습니다.

Highlights

  • 디자인 토큰 업데이트: Tokens Studio for Figma에서 생성된 최신 디자인 토큰 데이터가 tokens.json 파일에 반영되었습니다.
  • 토큰 구조 확장: 기존의 기본 색상 및 폰트 설정 외에 Primitive 및 Semantic(Color, Number) 토큰 세트가 새롭게 추가되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


토큰이 쌓여 디자인 시스템 완성 자동화 완료

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats existing design tokens and introduces a large set of new tokens organized under Primitive and Semantic categories. The review feedback identifies a critical structural issue where the new top-level keys are not compatible with the current build script, which will prevent the tokens from being exported to the application. Additionally, the reviewer pointed out several recurring typos in token names, such as "Neutural" and "Iversed", and a naming inconsistency in the radius tokens that should be corrected for better maintainability.

Comment thread packages/design-tokens/tokens/tokens.json
Comment thread packages/design-tokens/tokens/tokens.json
Comment thread packages/design-tokens/tokens/tokens.json
Comment thread packages/design-tokens/tokens/tokens.json
@wlrnjs wlrnjs merged commit b727dd5 into develop May 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore 의존성 업데이트, 환경 세팅, 빌드 설정 등 유지보수 작업 D-0 12시간 이내에 처리가 필요합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants