feat: 디자인 토큰 자동화 파일 구성#45
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 피그마 디자인 토큰을 자동화된 방식으로 관리하기 위한 초기 설정을 도입합니다. Style Dictionary를 활용하여 디자인 토큰을 중앙에서 정의하고, 이를 CSS 변수, JavaScript 모듈, 그리고 Tailwind CSS 프리셋과 같은 다양한 개발 환경에서 활용할 수 있는 형식으로 자동 생성합니다. 이는 디자인과 개발 간의 일관성을 보장하고 수동 작업을 줄이는 데 기여할 것입니다. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. 디자인 토큰, 일관된 색과 글꼴, 자동화된 꿈. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request establishes a design tokens package utilizing Style Dictionary, providing source tokens and auto-generated outputs for CSS, JS, and Tailwind. The reviewer recommends removing the dist directory from the repository to prevent committing build artifacts and suggests reclassifying build-specific tools as development dependencies.
|
|
||
| # Build outputs | ||
| dist/ | ||
| !packages/design-tokens/dist/ |
| "dependencies": { | ||
| "@tokens-studio/sd-transforms": "^1.2.0", | ||
| "style-dictionary": "^4.0.0" | ||
| } |
There was a problem hiding this comment.
style-dictionary와 @tokens-studio/sd-transforms는 디자인 토큰을 빌드하는 과정에서만 사용되는 도구이므로, 런타임 의존성(dependencies)이 아닌 개발 의존성(devDependencies)으로 분류하는 것이 적절합니다.
| "dependencies": { | |
| "@tokens-studio/sd-transforms": "^1.2.0", | |
| "style-dictionary": "^4.0.0" | |
| } | |
| "devDependencies": { | |
| "@tokens-studio/sd-transforms": "^1.2.0", | |
| "style-dictionary": "^4.0.0" | |
| } |
References
- In a monorepo, it is acceptable to keep dependencies in a single project's package.json initially. This suggestion correctly reclassifies them within the project scope rather than moving them to the root.
Pull Request
관련 이슈
작업 내용
참고 사항
체크리스트