Indicate flag differences from standard in logs#105
Open
asilverthorn wants to merge 4 commits intoff6wc:mainfrom
Open
Indicate flag differences from standard in logs#105asilverthorn wants to merge 4 commits intoff6wc:mainfrom
asilverthorn wants to merge 4 commits intoff6wc:mainfrom
Conversation
Merged
asilverthorn
added a commit
that referenced
this pull request
Sep 24, 2023
#108 (Ironmog Mode flag -- asilverthorn) #107 (Added flags for tiered equipable equipment and tiered equipable relics -- doubledown) #106 (Added flag to customize list of potential item rewards from checks -- doubledown) #105 (Indicate flag differences from standard in logs -- some changes, but user-facing changes are disabled -- asilverthorn) #103 (Improve events.py error message -- Overswarm) #102 (Split esper spells flags into separate flags for spells and learn rate -- doubledown) #101 (Throwable and Restoratives objectives -- doubledown) #94 (Add BC's nicer poison mod to reduce pixelation while moving -- note that it's always on now -- franklin) #104 (Add Mt. Zozo and Lone Wolf to NFP -- TheShwantz27) Other changes: - Updated README.md with new links - Added documentation from AtmaTek for posterity - Made Lone Wolf character reward play the characters theme, Updated Terra's theme to "Terra's Theme" from "Awakening", and fixed the Relm's theme playing at the end of Owzer's mansion if it's a different character - Version = 1.4d --------- Co-authored-by: Franklin Jen <franklinjen@gmail.com> Co-authored-by: dbldown11 <45882117+dbldown11@users.noreply.github.com> Co-authored-by: Overswarm <evandowning@gmail.com> Co-authored-by: Brian - TheShwantz27 <briguy7727@yahoo.com>
asilverthorn
added
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing standard (at this time, ULS4) flags in the code; when a log is generated, it will indicate a difference from standard with a ! prepended to the name of the flag. Doing so required giving each log output a "unique_name" that is used in the lookup of the standard_flags dict.
Tests:
!Seed 7bdwqo40qoht