Skip to content

[eslint-plugin] accept numeric values for grid line properties #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmedsadid wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

[eslint-plugin] accept numeric values for grid line properties #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,20 @@ const eslintTester = new ESLintTester({

eslintTester.run('stylex-valid-styles', rule.default, {
valid: [
// issue #1701 — numeric values are valid for grid line properties
`
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
foo: {
gridColumn: 1,
gridColumnStart: 1,
gridColumnEnd: 3,
gridRow: 2,
gridRowStart: -1,
gridRowEnd: 4,
}
});
`,
// test for local static variables
`
import * as stylex from '@stylexjs/stylex';
Expand Down
6 changes: 5 additions & 1 deletion packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,11 @@ const absoluteSize: RuleCheck = makeUnionRule(
makeLiteralRule('xx-large'),
);
const fontFamily: RuleCheck = isString;
const gridLine: RuleCheck = makeUnionRule(makeLiteralRule('auto'), isString);
const gridLine: RuleCheck = makeUnionRule(
makeLiteralRule('auto'),
isString,
isNumber,
);
const gridTemplate: RuleCheck = makeUnionRule(
makeLiteralRule('none'),
makeLiteralRule('subgrid'),
Expand Down
Loading