[eslint-plugin] accept numeric values for grid line properties#1730
Open
ahmedsadid wants to merge 1 commit into
Open
[eslint-plugin] accept numeric values for grid line properties#1730ahmedsadid wants to merge 1 commit into
ahmedsadid wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
The
stylex-valid-stylesrule rejected numeric literals for grid line properties, even though they are valid CSS. WritinggridColumnStart: 1triggered a lint error:This happened because the shared
gridLinerule incssProperties.jsonly permittedautoand string values, not numbers.This change adds
isNumberto thegridLinerule. Because all six grid line properties —gridColumn,gridColumnStart,gridColumnEnd,gridRow,gridRowStart,gridRowEnd(andgridArea) — derive fromgridLine, the single change fixes them all. This mirrors the existingzIndexrule, which already usesmakeUnionRule(makeLiteralRule('auto'), isNumber), and follows the precedent set in #1522 / #1523 for accepting bare numbers.Linked PR/Issues
Fixes #1701
Additional Context
Added valid test cases covering numeric values for all affected properties, including a negative integer (
gridRowStart: -1), which is valid for grid lines. Full plugin suite passes (548 tests).Pre-flight checklist