Skip to content

[Nexthop] fixmyfboss alias for BNHP and CNHP #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-nexthop wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −16
Open

[Nexthop] fixmyfboss alias for BNHP and CNHP #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions fboss/util/fixmyfboss/platform_name_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,25 @@ def sanitize_platform_name(platform_name_from_bios: str) -> str:
"""
platform_name_upper = platform_name_from_bios.upper()

if platform_name_upper in ["MINIPACK3", "MINIPACK3_MCB"]:
return "MONTBLANC"
name_translations = {
"MINIPACK3": "MONTBLANC",
"MINIPACK3_MCB": "MONTBLANC",
"JANGA": "JANGA800BIC",
"TAHAN": "TAHAN800BC",
"MERU800BIAB": "MERU800BIA",
"WEDGE800BNHP": "WEDGE800BACT",
"WEDGE800CNHP": "WEDGE800CACT",
}

if platform_name_upper == "JANGA":
return "JANGA800BIC"

if platform_name_upper == "TAHAN":
return "TAHAN800BC"

# MERU800BIAB and MERU800BIA have equivalent configs
if platform_name_upper == "MERU800BIAB":
return "MERU800BIA"

return platform_name_upper
return name_translations.get(platform_name_upper, platform_name_upper)


def get_string_file_content(path: str) -> Optional[str]:
"""
Read string content from file. Returns None if file doesn't exist or can't be read.
"""
try:
with open(path, "r") as f:
with open(path) as f:
return f.read().strip()
except Exception:
return None
Expand All @@ -61,9 +58,8 @@ def get_platform_name_from_bios() -> str:
raise RuntimeError(error_msg)

standard_out = standard_out.strip()
result = sanitize_platform_name(standard_out)

return result
return sanitize_platform_name(standard_out)


def get_platform_name() -> Optional[str]:
Expand Down
Loading