Skip to content

[Nexthop] fixmyfboss alias for BNHP and CNHP#1312

Open
andrew-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:agent-alias-bnhp-and-cnhp
Open

[Nexthop] fixmyfboss alias for BNHP and CNHP#1312
andrew-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:agent-alias-bnhp-and-cnhp

Conversation

@andrew-nexthop

@andrew-nexthop andrew-nexthop commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

#1266 and #1277 added the alias for the platform services but we also need to update this equivalent mapping

Test Plan

have the same alias behavior in .cpp and .py versions of PlatformNameLib

@andrew-nexthop andrew-nexthop requested review from a team as code owners June 22, 2026 14:17
@meta-cla meta-cla Bot added the CLA Signed label Jun 22, 2026
@andrew-nexthop andrew-nexthop changed the title agent alias for BNHP and CNHP [Nexthop] agent alias for BNHP and CNHP Jun 22, 2026
@meta-codesync

meta-codesync Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D109318930.

@srikrishnagopu

Copy link
Copy Markdown
Contributor

Can we not use aliasing for Agent and Qsfp service ?

I would suggest to define new platform type for both the platforms and add the relevant code changes to support it.

Signed-off-by: andrew-nexthop <andrew@nexthop.ai>
@andrew-nexthop andrew-nexthop force-pushed the agent-alias-bnhp-and-cnhp branch from 51c98a7 to 341ad9a Compare June 25, 2026 21:09
@facebook-github-tools

Copy link
Copy Markdown

@andrew-nexthop has updated the pull request. You must reimport the pull request before landing.

@andrew-nexthop andrew-nexthop changed the title [Nexthop] agent alias for BNHP and CNHP [Nexthop] fixmyfboss alias for BNHP and CNHP Jun 25, 2026
@andrew-nexthop

Copy link
Copy Markdown
Contributor Author

Can we not use aliasing for Agent and Qsfp service ?

I would suggest to define new platform type for both the platforms and add the relevant code changes to support it.

i updated this PR to only include the change for the python platform alias. WEDGE800BNHP agent/qsfp service code will be in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants