[Nexthop] fixmyfboss alias for BNHP and CNHP#1312
Open
andrew-nexthop wants to merge 1 commit into
Open
Conversation
Contributor
|
@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D109318930. |
Contributor
|
Can we not use aliasing for Agent and Qsfp service ? I would suggest to define new platform type for both the platforms and add the relevant code changes to support it. |
Signed-off-by: andrew-nexthop <andrew@nexthop.ai>
51c98a7 to
341ad9a
Compare
|
@andrew-nexthop has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
i updated this PR to only include the change for the python platform alias. WEDGE800BNHP agent/qsfp service code will be in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
#1266 and #1277 added the alias for the platform services but we also need to update this equivalent mapping
Test Plan
have the same alias behavior in .cpp and .py versions of PlatformNameLib