fix(ci): authorize Repo Owners for visual acceptance - #5592
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
fix/visual-acceptance-repo-owner
branch
from
August 27, 2026 07:24
1f85e0c to
6d4cf25
Compare
cixzhang
force-pushed
the
fix/visual-acceptance-repo-owner
branch
from
August 27, 2026 07:30
6d4cf25 to
1efb73c
Compare
cixzhang
commented
Aug 27, 2026
cixzhang
left a comment
Contributor
Author
There was a problem hiding this comment.
Can't approve my own PR, so: semantic approve. The Repo Owner boundary, dependency-free acceptance, record compatibility, and workflow permissions all pass.
[Reviewed by Robohands]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub's collaborator-permission endpoint reports repository owners as top-level
permission: writewithrole_name: Repo Owner, while effective capabilities live underuser.permissions. Readinguser.permissiontherefore refused every decision, and treating top-levelwriteas authority would admit ordinary writers.#5591 restored effective
maintain/adminauthorization. This follow-up preserves the endpoint's permission and role, adds the exact repository-owner fallback, and keeps old acceptance records valid.A live authorized replay then exposed a second blocker: the archive job has no package install, but
visual-acceptance.mjseagerly importedpngjsbefore running the dependency-freeacceptpath.What
maintain/adminor exactRepo Ownersucceeds; ordinarywrite, unknown, and 404 identities fail.author_association.maintain/adminacceptance records valid.pngjsonly for post-merge pixel comparison, so the read-only authorization and archive path need no dependency install.Risk
Low. Authorization remains fail-closed and does not admit general write access. The lazy dependency load is covered by running acceptance from an isolated copy with no
node_modules.Testing
actionlint .github/workflows/visual-acceptance.ymlpnpm check:repo66ef14d69ed5f32c469c78cb2e8395bfe23ec633, run33041576630/2